From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Eric Blake <eblake@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, tangchen@cn.fujitsu.com,
chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
imammedo@redhat.com, guz.fnst@cn.fujitsu.com,
anshul.makkar@profitbricks.com, afaerber@suse.de,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] send-email: ask confirmation if given encoding name is very short
Date: Wed, 18 Feb 2015 13:58:12 -0500 [thread overview]
Message-ID: <20150218185812.GC7257@peff.net> (raw)
In-Reply-To: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>
On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote:
> Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
> this question:
>
> Which 8bit encoding should I declare [UTF-8]?
>
> We already have a mechanism to avoid accepting a mistyped e-mail
> address (we ask to confirm when the given address lacks "@" in it);
> reuse it to trigger the same confirmation when given a very short
> answer. As a typical charset name is probably at least 4 chars or
> longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
> prevent such a mistake.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Will mark to be merged to 'next'.
Probably belated review, but this looks good to me.
-Peff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, tangchen@cn.fujitsu.com,
guz.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
Geert Uytterhoeven <geert@linux-m68k.org>,
anshul.makkar@profitbricks.com, chen.fan.fnst@cn.fujitsu.com,
imammedo@redhat.com, afaerber@suse.de, git@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] send-email: ask confirmation if given encoding name is very short
Date: Wed, 18 Feb 2015 13:58:12 -0500 [thread overview]
Message-ID: <20150218185812.GC7257@peff.net> (raw)
In-Reply-To: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>
On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote:
> Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
> this question:
>
> Which 8bit encoding should I declare [UTF-8]?
>
> We already have a mechanism to avoid accepting a mistyped e-mail
> address (we ask to confirm when the given address lacks "@" in it);
> reuse it to trigger the same confirmation when given a very short
> answer. As a typical charset name is probably at least 4 chars or
> longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
> prevent such a mistake.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Will mark to be merged to 'next'.
Probably belated review, but this looks good to me.
-Peff
next prev parent reply other threads:[~2015-02-18 18:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 7:27 [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Zhu Guihua
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 1/7] cpu: introduce CpuTopoInfo structure for argument simplification Zhu Guihua
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 2/7] qom/cpu: move register_vmstate to common CPUClass.realizefn Zhu Guihua
2015-01-29 14:04 ` Igor Mammedov
2015-02-09 8:30 ` Chen Fan
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 3/7] qom/cpu: move apic vmstate register into x86_cpu_apic_realize Zhu Guihua
2015-01-29 14:07 ` Igor Mammedov
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 4/7] monitor: use cc->get_arch_id as the cpu index Zhu Guihua
2015-01-29 14:12 ` Igor Mammedov
2015-01-29 14:21 ` Peter Krempa
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 5/7] acpi:cpu hotplug: set pcmachine as icc bus' hotplug handler Zhu Guihua
2015-01-29 14:18 ` Igor Mammedov
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 6/7] cpu: add device_add foo-x86_64-cpu support Zhu Guihua
2015-01-29 14:46 ` Igor Mammedov
2015-01-29 16:01 ` Eduardo Habkost
2015-01-29 16:39 ` Andreas Färber
2015-02-06 5:27 ` Chen Fan
2015-01-14 7:27 ` [Qemu-devel] [PATCH v3 7/7] i386/cpu: add instance finalize callback Zhu Guihua
2015-01-29 15:25 ` Igor Mammedov
2015-02-05 11:49 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Stefan Hajnoczi
2015-02-05 15:25 ` Eric Blake
2015-02-05 15:25 ` Eric Blake
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:57 ` Jeff King
2015-02-05 19:57 ` Jeff King
2015-02-05 20:17 ` Junio C Hamano
2015-02-05 20:17 ` Junio C Hamano
2015-02-04 9:07 ` Invalid responses to 8bit encoding and In-Reply-To questions Geert Uytterhoeven
2015-02-04 18:34 ` Junio C Hamano
2015-04-01 10:53 ` Guilhem Bichot
2015-04-01 18:03 ` Junio C Hamano
2015-02-06 19:33 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Jeff King
2015-02-06 19:33 ` Jeff King
2015-02-16 22:34 ` [PATCH] send-email: ask confirmation if given encoding name is very short Junio C Hamano
2015-02-16 22:34 ` [Qemu-devel] " Junio C Hamano
2015-02-18 18:58 ` Jeff King [this message]
2015-02-18 18:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218185812.GC7257@peff.net \
--to=peff@peff.net \
--cc=afaerber@suse.de \
--cc=anshul.makkar@profitbricks.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=geert@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=tangchen@cn.fujitsu.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.