[PATCH] Staging: i2o: Remove assignment in if condition

[PATCH] Staging: i2o: Remove assignment in if condition

[Vatika Harlalka]

This patch removes the assignment in an if condition to do away with
the checkpatch warning :'do not use assignment in if condition'.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/i2o/bus-osm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/i2o/bus-osm.c b/drivers/staging/i2o/bus-osm.c
index 7aa0339..70b15b2 100644
--- a/drivers/staging/i2o/bus-osm.c
+++ b/drivers/staging/i2o/bus-osm.c
@@ -67,9 +67,9 @@ static ssize_t i2o_bus_store_scan(struct device *d,
 				  const char *buf, size_t count)
 {
 	struct i2o_device *i2o_dev = to_i2o_device(d);
-	int rc;
+	int rc = i2o_bus_scan(i2o_dev);
 
-	if ((rc = i2o_bus_scan(i2o_dev)))
+	if (rc)
 		osm_warn("bus scan failed %d\n", rc);
 
 	return count;
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: i2o: Remove assignment in if condition

[Julia Lawall]

On Thu, 19 Feb 2015, Vatika Harlalka wrote:

> This patch removes the assignment in an if condition to do away with
> the checkpatch warning :'do not use assignment in if condition'.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/i2o/bus-osm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/i2o/bus-osm.c b/drivers/staging/i2o/bus-osm.c
> index 7aa0339..70b15b2 100644
> --- a/drivers/staging/i2o/bus-osm.c
> +++ b/drivers/staging/i2o/bus-osm.c
> @@ -67,9 +67,9 @@ static ssize_t i2o_bus_store_scan(struct device *d,
>  				  const char *buf, size_t count)
>  {
>  	struct i2o_device *i2o_dev = to_i2o_device(d);
> -	int rc;
> +	int rc = i2o_bus_scan(i2o_dev);

Unlike to_i2o_device, which is just an accessor function (a macro 
actually), i2o_bus_scan does real work.  I think it would be better as a 
top-level statement, right before its error checking code.

julia

>  
> -	if ((rc = i2o_bus_scan(i2o_dev)))
> +	if (rc)
>  		osm_warn("bus scan failed %d\n", rc);
>  
>  	return count;
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150218190158.GA17577%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>