* [PATCH] Staging: i2o: Join quoted string split across lines
@ 2015-02-18 19:49 Vatika Harlalka
2015-02-18 20:11 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Vatika Harlalka @ 2015-02-18 19:49 UTC (permalink / raw)
To: outreachy-kernel
This patch removes the checkpatch.pl warnings "quoted string split accross lines"
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
drivers/staging/i2o/driver.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/i2o/driver.c b/drivers/staging/i2o/driver.c
index 111c3ed..06119bb 100644
--- a/drivers/staging/i2o/driver.c
+++ b/drivers/staging/i2o/driver.c
@@ -102,8 +102,7 @@ int i2o_driver_register(struct i2o_driver *drv)
for (i = 0; i2o_drivers[i]; i++)
if (i >= i2o_max_drivers) {
- osm_err("too many drivers registered, increase "
- "max_drivers\n");
+ osm_err("too many drivers registered, increase max_drivers\n");
spin_unlock_irqrestore(&i2o_drivers_lock, flags);
rc = -EFAULT;
goto out;
@@ -244,8 +243,8 @@ int i2o_driver_dispatch(struct i2o_controller *c, u32 m)
}
if (unlikely(!drv->reply)) {
- osm_debug("%s: Reply to driver %s, but no reply function"
- " defined!\n", c->name, drv->name);
+ osm_debug("%s: Reply to driver %s, but no reply function defined!\n",
+ c->name, drv->name);
return -EIO;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: i2o: Join quoted string split across lines
2015-02-18 19:49 [PATCH] Staging: i2o: Join quoted string split across lines Vatika Harlalka
@ 2015-02-18 20:11 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2015-02-18 20:11 UTC (permalink / raw)
To: Vatika Harlalka; +Cc: outreachy-kernel
On Thu, 19 Feb 2015, Vatika Harlalka wrote:
> This patch removes the checkpatch.pl warnings "quoted string split accross lines"
drivers/staging/i2o seems to be code that is on the way out of the Linux
kernel rather than on the way in. See commit 2cbf7fe2d5. Perhaps try to
avoid working on these files.
julia
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> drivers/staging/i2o/driver.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/i2o/driver.c b/drivers/staging/i2o/driver.c
> index 111c3ed..06119bb 100644
> --- a/drivers/staging/i2o/driver.c
> +++ b/drivers/staging/i2o/driver.c
> @@ -102,8 +102,7 @@ int i2o_driver_register(struct i2o_driver *drv)
>
> for (i = 0; i2o_drivers[i]; i++)
> if (i >= i2o_max_drivers) {
> - osm_err("too many drivers registered, increase "
> - "max_drivers\n");
> + osm_err("too many drivers registered, increase max_drivers\n");
> spin_unlock_irqrestore(&i2o_drivers_lock, flags);
> rc = -EFAULT;
> goto out;
> @@ -244,8 +243,8 @@ int i2o_driver_dispatch(struct i2o_controller *c, u32 m)
> }
>
> if (unlikely(!drv->reply)) {
> - osm_debug("%s: Reply to driver %s, but no reply function"
> - " defined!\n", c->name, drv->name);
> + osm_debug("%s: Reply to driver %s, but no reply function defined!\n",
> + c->name, drv->name);
> return -EIO;
> }
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150218194915.GA28794%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-18 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 19:49 [PATCH] Staging: i2o: Join quoted string split across lines Vatika Harlalka
2015-02-18 20:11 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.