All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: mjg59@srcf.ucam.org, dvhart@infradead.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, A.Sloman@cs.bham.ac.uk,
	computersforpeace@gmail.com
Subject: Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS
Date: Wed, 18 Feb 2015 20:09:28 +0100	[thread overview]
Message-ID: <201502182009.28962@pali> (raw)
In-Reply-To: <6193126.UlCB3asGVW@xps13>

[-- Attachment #1: Type: Text/Plain, Size: 1173 bytes --]

On Friday 13 February 2015 15:30:42 Gabriele Mazzotta wrote:
> On Tuesday 10 February 2015 10:36:21 Pali Rohár wrote:
> > On Wednesday 14 January 2015 15:05:57 Gabriele Mazzotta 
wrote:
> > > The ambient light sensor doesn't act like an input
> > > trigger, so it has to be kept separate. The sensor
> > > readings are used to determine whether the conditions to
> > > change the keyboard illumination are satisfied or not the
> > > moment an input trigger is used. Ambient light changes
> > > alone can't change the keyboard backlight illumination
> > > and don't restart the timer.
> > > 
> > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> > > ---
> > 
> > Gabriele, can you look and integrate this patch into full
> > keyboard backlight support? Ideally send new full one...
> 
> I will do that soon.
> 
> Darren, do you prefer one single patch or should I send Pali's
> patch and my changes in different patches (that can be later
> squashed) to make the review easier?

Gabriele, I think you should send patch now. Just integrate all 
changes to one (this could be easy) and send it.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2015-02-18 19:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 14:05 [PATCH] dell-laptop: use dedicated sysfs file for ALS Gabriele Mazzotta
2015-01-14 14:07 ` Gabriele Mazzotta
2015-01-18 18:08   ` Darren Hart
2015-01-18 18:34     ` Gabriele Mazzotta
2015-01-21 18:38       ` Darren Hart
2015-01-21 22:32         ` Gabriele Mazzotta
2015-01-18 17:52 ` Darren Hart
2015-02-10  9:36 ` Pali Rohár
2015-02-13 14:30   ` Gabriele Mazzotta
2015-02-18 19:09     ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201502182009.28962@pali \
    --to=pali.rohar@gmail.com \
    --cc=A.Sloman@cs.bham.ac.uk \
    --cc=computersforpeace@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gabriele.mzt@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.