All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: dvhart@infradead.org
Cc: mjg59@srcf.ucam.org, pali.rohar@gmail.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, A.Sloman@cs.bham.ac.uk,
	computersforpeace@gmail.com
Subject: Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS
Date: Wed, 14 Jan 2015 15:07:21 +0100	[thread overview]
Message-ID: <9352624.oIKUSW0aDp@xps13> (raw)
In-Reply-To: <1421244357-31103-1-git-send-email-gabriele.mzt@gmail.com>

Hi,

I decided to remove "als" from input_triggers and created a dedicated
sysfs file for it. Having it there was wrong and misleading.
I also updated the documentation to reflect this change and fixed the
wrong description of als_setting, now used for als_enabled.

Is returning -ENODEV only when writing to als_enabled the right thing
to do or should it be returned also when reading als_enabled?

Thanks,
Gabriele

  reply	other threads:[~2015-01-14 14:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 14:05 [PATCH] dell-laptop: use dedicated sysfs file for ALS Gabriele Mazzotta
2015-01-14 14:07 ` Gabriele Mazzotta [this message]
2015-01-18 18:08   ` Darren Hart
2015-01-18 18:34     ` Gabriele Mazzotta
2015-01-21 18:38       ` Darren Hart
2015-01-21 22:32         ` Gabriele Mazzotta
2015-01-18 17:52 ` Darren Hart
2015-02-10  9:36 ` Pali Rohár
2015-02-13 14:30   ` Gabriele Mazzotta
2015-02-18 19:09     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9352624.oIKUSW0aDp@xps13 \
    --to=gabriele.mzt@gmail.com \
    --cc=A.Sloman@cs.bham.ac.uk \
    --cc=computersforpeace@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.