* drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-18 16:09 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-02-18 16:09 UTC (permalink / raw)
To: linux-arm-kernel
The ptn3460 driver recently started usign the gpiod interface
which is only available on platforms that come with GPIOLIB
support, resulting in a compile-time error:
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
gpiod_set_value(ps8622->gpio_rst, 0);
^
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
^
Similarly, the newly added ps8622 driver started out with the same
problem.
This patch adds explicit Kconfig dependencies to avoid trying to
build invalid configurations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index acef3223772c..8f068a0e86a5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -7,6 +7,7 @@ config DRM_PTN3460
tristate "PTN3460 DP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_KMS_HELPER
select DRM_PANEL
---help---
@@ -16,6 +17,7 @@ config DRM_PS8622
tristate "Parade eDP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_PANEL
select DRM_KMS_HELPER
select BACKLIGHT_LCD_SUPPORT
^ permalink raw reply related [flat|nested] 8+ messages in thread
* drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-18 16:09 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-02-18 16:09 UTC (permalink / raw)
To: David Airlie
Cc: Vincent Palatin, Andrew Bresticker, linux-kernel, dri-devel,
Javier Martinez Canillas, Sjoerd Simons, Thierry Reding,
Gustavo Padovan, Ajay Kumar, linux-arm-kernel, Rahul Sharma
The ptn3460 driver recently started usign the gpiod interface
which is only available on platforms that come with GPIOLIB
support, resulting in a compile-time error:
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
gpiod_set_value(ps8622->gpio_rst, 0);
^
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
^
Similarly, the newly added ps8622 driver started out with the same
problem.
This patch adds explicit Kconfig dependencies to avoid trying to
build invalid configurations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index acef3223772c..8f068a0e86a5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -7,6 +7,7 @@ config DRM_PTN3460
tristate "PTN3460 DP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_KMS_HELPER
select DRM_PANEL
---help---
@@ -16,6 +17,7 @@ config DRM_PS8622
tristate "Parade eDP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_PANEL
select DRM_KMS_HELPER
select BACKLIGHT_LCD_SUPPORT
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-18 16:09 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-02-18 16:09 UTC (permalink / raw)
To: David Airlie
Cc: dri-devel, Vincent Palatin, Andrew Bresticker, Sean Paul,
Rahul Sharma, Ajay Kumar, Javier Martinez Canillas,
Thierry Reding, Inki Dae, Sjoerd Simons, Gustavo Padovan,
linux-arm-kernel, linux-kernel
The ptn3460 driver recently started usign the gpiod interface
which is only available on platforms that come with GPIOLIB
support, resulting in a compile-time error:
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
gpiod_set_value(ps8622->gpio_rst, 0);
^
drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
^
Similarly, the newly added ps8622 driver started out with the same
problem.
This patch adds explicit Kconfig dependencies to avoid trying to
build invalid configurations.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index acef3223772c..8f068a0e86a5 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -7,6 +7,7 @@ config DRM_PTN3460
tristate "PTN3460 DP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_KMS_HELPER
select DRM_PANEL
---help---
@@ -16,6 +17,7 @@ config DRM_PS8622
tristate "Parade eDP/LVDS bridge"
depends on DRM
depends on OF
+ depends on GPIOLIB
select DRM_PANEL
select DRM_KMS_HELPER
select BACKLIGHT_LCD_SUPPORT
^ permalink raw reply related [flat|nested] 8+ messages in thread
* drm: bridge: ps8622 and ptn3460 depend on gpiolib
2015-02-18 16:09 ` Arnd Bergmann
@ 2015-02-18 19:54 ` Javier Martinez Canillas
-1 siblings, 0 replies; 8+ messages in thread
From: Javier Martinez Canillas @ 2015-02-18 19:54 UTC (permalink / raw)
To: linux-arm-kernel
Hello Arnd,
On 02/18/2015 05:09 PM, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-18 19:54 ` Javier Martinez Canillas
0 siblings, 0 replies; 8+ messages in thread
From: Javier Martinez Canillas @ 2015-02-18 19:54 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie
Cc: dri-devel, Vincent Palatin, Andrew Bresticker, Sean Paul,
Rahul Sharma, Ajay Kumar, Thierry Reding, Inki Dae, Sjoerd Simons,
Gustavo Padovan, linux-arm-kernel, linux-kernel
Hello Arnd,
On 02/18/2015 05:09 PM, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 8+ messages in thread
* drm: bridge: ps8622 and ptn3460 depend on gpiolib
2015-02-18 16:09 ` Arnd Bergmann
(?)
@ 2015-02-19 9:32 ` Thierry Reding
-1 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2015-02-19 9:32 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150219/355be74c/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-19 9:32 ` Thierry Reding
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2015-02-19 9:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, dri-devel, Vincent Palatin, Andrew Bresticker,
Sean Paul, Rahul Sharma, Ajay Kumar, Javier Martinez Canillas,
Inki Dae, Sjoerd Simons, Gustavo Padovan, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: drm: bridge: ps8622 and ptn3460 depend on gpiolib
@ 2015-02-19 9:32 ` Thierry Reding
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Reding @ 2015-02-19 9:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, dri-devel, Vincent Palatin, Andrew Bresticker,
Sean Paul, Rahul Sharma, Ajay Kumar, Javier Martinez Canillas,
Inki Dae, Sjoerd Simons, Gustavo Padovan, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-19 9:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 16:09 drm: bridge: ps8622 and ptn3460 depend on gpiolib Arnd Bergmann
2015-02-18 16:09 ` Arnd Bergmann
2015-02-18 16:09 ` Arnd Bergmann
2015-02-18 19:54 ` Javier Martinez Canillas
2015-02-18 19:54 ` Javier Martinez Canillas
2015-02-19 9:32 ` Thierry Reding
2015-02-19 9:32 ` Thierry Reding
2015-02-19 9:32 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.