* [PATCH] Staging: media: Remove unneeded void return
@ 2015-02-19 10:50 Vatika Harlalka
2015-02-19 11:04 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Vatika Harlalka @ 2015-02-19 10:50 UTC (permalink / raw)
To: outreachy-kernel
This patch is to remove return statement from void function.
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
drivers/staging/media/tlg2300/pd-alsa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/tlg2300/pd-alsa.c b/drivers/staging/media/tlg2300/pd-alsa.c
index e23f437..7a07a1d 100644
--- a/drivers/staging/media/tlg2300/pd-alsa.c
+++ b/drivers/staging/media/tlg2300/pd-alsa.c
@@ -195,7 +195,6 @@ static void complete_handler_audio(struct urb *urb)
ret = usb_submit_urb(urb, GFP_ATOMIC);
if (ret < 0)
log("audio urb failed (errcod = %i)", ret);
- return;
}
static int fire_audio_urb(struct poseidon *p)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: media: Remove unneeded void return
2015-02-19 10:50 [PATCH] Staging: media: Remove unneeded void return Vatika Harlalka
@ 2015-02-19 11:04 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2015-02-19 11:04 UTC (permalink / raw)
To: Vatika Harlalka; +Cc: outreachy-kernel
On Thu, 19 Feb 2015, Vatika Harlalka wrote:
> This patch is to remove return statement from void function.
>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
> drivers/staging/media/tlg2300/pd-alsa.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/tlg2300/pd-alsa.c b/drivers/staging/media/tlg2300/pd-alsa.c
> index e23f437..7a07a1d 100644
> --- a/drivers/staging/media/tlg2300/pd-alsa.c
> +++ b/drivers/staging/media/tlg2300/pd-alsa.c
> @@ -195,7 +195,6 @@ static void complete_handler_audio(struct urb *urb)
> ret = usb_submit_urb(urb, GFP_ATOMIC);
> if (ret < 0)
> log("audio urb failed (errcod = %i)", ret);
> - return;
You could consider getting rid of all of the uses of the non-standard log
macro in this driver.
Some cases are for just indicating the entry or exit from a function.
These could be just dropped competely, as the kernel provides other
mechanisms for function tracing.
julia
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-19 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-19 10:50 [PATCH] Staging: media: Remove unneeded void return Vatika Harlalka
2015-02-19 11:04 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.