[PATCH] Staging: media: Remove unneeded log macro

[PATCH] Staging: media: Remove unneeded log macro

[Vatika Harlalka]

This patch is to remove unneeded log macros which only
indicate entry/exit from a function. The kernel provides 
mechanisms for function tracing so these can be dropped.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/media/tlg2300/pd-main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/tlg2300/pd-main.c b/drivers/staging/media/tlg2300/pd-main.c
index b31f479..c2dd3b4 100644
--- a/drivers/staging/media/tlg2300/pd-main.c
+++ b/drivers/staging/media/tlg2300/pd-main.c
@@ -207,7 +207,6 @@ void poseidon_delete(struct kref *kref)
 		pd->interface = NULL;
 	}
 	kfree(pd);
-	log();
 }
 
 static int firmware_download(struct usb_device *udev)
@@ -538,7 +537,6 @@ static int __init poseidon_init(void)
 
 static void __exit poseidon_exit(void)
 {
-	log();
 	unregister_pm_notifier(&pm_notifer);
 	usb_deregister(&poseidon_driver);
 }
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: media: Remove unneeded log macro

[Arnd Bergmann]

On Friday 20 February 2015 04:04:12 Vatika Harlalka wrote:
> This patch is to remove unneeded log macros which only
> indicate entry/exit from a function. The kernel provides 
> mechanisms for function tracing so these can be dropped.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>

I believe this driver was removed already, so the patch no longer
applies.

> 
> diff --git a/drivers/staging/media/tlg2300/pd-main.c b/drivers/staging/media/tlg2300/pd-main.c
> index b31f479..c2dd3b4 100644
> --- a/drivers/staging/media/tlg2300/pd-main.c
> +++ b/drivers/staging/media/tlg2300/pd-main.c
> @@ -207,7 +207,6 @@ void poseidon_delete(struct kref *kref)
>                 pd->interface = NULL;
>         }
>         kfree(pd);
> -       log();
>  }
>  
>  static int firmware_download(struct usb_device *udev)

Doing this is a good idea in general, but if I did this for another
driver, I would remove the macro definition along with the uses.

	Arnd