* [patch] ethtool: use "ops" name consistenty in ethtool_set_rxfh()
@ 2015-02-20 10:54 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-02-20 10:54 UTC (permalink / raw)
To: David S. Miller
Cc: Ben Hutchings, Amir Vadai, Eric Dumazet, Venkata Duvvuru,
Ed Swierk, Jiri Pirko, Govindarajulu Varadarajan, Eyal Perry,
netdev, kernel-janitors
"dev->ethtool_ops" and "ops" are the same, but we should use "ops"
everywhere to be consistent.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 91f74f3..eb0c3ac 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -789,7 +789,7 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
if (ops->get_rxfh_indir_size)
dev_indir_size = ops->get_rxfh_indir_size(dev);
if (ops->get_rxfh_key_size)
- dev_key_size = dev->ethtool_ops->get_rxfh_key_size(dev);
+ dev_key_size = ops->get_rxfh_key_size(dev);
if (copy_from_user(&rxfh, useraddr, sizeof(rxfh)))
return -EFAULT;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ethtool: use "ops" name consistenty in ethtool_set_rxfh()
@ 2015-02-20 10:54 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-02-20 10:54 UTC (permalink / raw)
To: David S. Miller
Cc: Ben Hutchings, Amir Vadai, Eric Dumazet, Venkata Duvvuru,
Ed Swierk, Jiri Pirko, Govindarajulu Varadarajan, Eyal Perry,
netdev, kernel-janitors
"dev->ethtool_ops" and "ops" are the same, but we should use "ops"
everywhere to be consistent.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 91f74f3..eb0c3ac 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -789,7 +789,7 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
if (ops->get_rxfh_indir_size)
dev_indir_size = ops->get_rxfh_indir_size(dev);
if (ops->get_rxfh_key_size)
- dev_key_size = dev->ethtool_ops->get_rxfh_key_size(dev);
+ dev_key_size = ops->get_rxfh_key_size(dev);
if (copy_from_user(&rxfh, useraddr, sizeof(rxfh)))
return -EFAULT;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ethtool: use "ops" name consistenty in ethtool_set_rxfh()
2015-02-20 10:54 ` Dan Carpenter
@ 2015-02-22 2:59 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-02-22 2:59 UTC (permalink / raw)
To: dan.carpenter
Cc: ben, amirv, edumazet, VenkatKumar.Duvvuru, eswierk, jiri, _govind,
eyalpe, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 20 Feb 2015 13:54:05 +0300
> "dev->ethtool_ops" and "ops" are the same, but we should use "ops"
> everywhere to be consistent.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ethtool: use "ops" name consistenty in ethtool_set_rxfh()
@ 2015-02-22 2:59 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-02-22 2:59 UTC (permalink / raw)
To: dan.carpenter
Cc: ben, amirv, edumazet, VenkatKumar.Duvvuru, eswierk, jiri, _govind,
eyalpe, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 20 Feb 2015 13:54:05 +0300
> "dev->ethtool_ops" and "ops" are the same, but we should use "ops"
> everywhere to be consistent.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-22 2:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 10:54 [patch] ethtool: use "ops" name consistenty in ethtool_set_rxfh() Dan Carpenter
2015-02-20 10:54 ` Dan Carpenter
2015-02-22 2:59 ` David Miller
2015-02-22 2:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.