* [patch] drm/exynos: IS_ERR() vs NULL bug
@ 2015-02-20 10:54 Dan Carpenter
2015-02-20 13:12 ` Gustavo Padovan
2015-03-06 12:49 ` Inki Dae
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-20 10:54 UTC (permalink / raw)
To: Inki Dae; +Cc: Seung-Woo Kim, dri-devel, Kyungmin Park, Kukjin Kim
of_iomap() doesn't return error pointers, it returns NULL on error.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index 63f02e2..9700461 100644
--- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
@@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)
of_node_put(i80_if_timings);
ctx->regs = of_iomap(dev->of_node, 0);
- if (IS_ERR(ctx->regs)) {
- ret = PTR_ERR(ctx->regs);
+ if (!ctx->regs) {
+ ret = -ENOMEM;
goto err_del_component;
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] drm/exynos: IS_ERR() vs NULL bug
2015-02-20 10:54 [patch] drm/exynos: IS_ERR() vs NULL bug Dan Carpenter
@ 2015-02-20 13:12 ` Gustavo Padovan
2015-03-06 12:49 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2015-02-20 13:12 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Kyungmin Park, Kukjin Kim, Seung-Woo Kim, dri-devel
Hi Dan,
2015-02-20 Dan Carpenter <dan.carpenter@oracle.com>:
> of_iomap() doesn't return error pointers, it returns NULL on error.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> index 63f02e2..9700461 100644
> --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> @@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)
> of_node_put(i80_if_timings);
>
> ctx->regs = of_iomap(dev->of_node, 0);
> - if (IS_ERR(ctx->regs)) {
> - ret = PTR_ERR(ctx->regs);
> + if (!ctx->regs) {
> + ret = -ENOMEM;
> goto err_del_component;
> }
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drm/exynos: IS_ERR() vs NULL bug
2015-02-20 10:54 [patch] drm/exynos: IS_ERR() vs NULL bug Dan Carpenter
2015-02-20 13:12 ` Gustavo Padovan
@ 2015-03-06 12:49 ` Inki Dae
1 sibling, 0 replies; 3+ messages in thread
From: Inki Dae @ 2015-03-06 12:49 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Seung-Woo Kim, dri-devel, Kyungmin Park, Kukjin Kim
On 2015년 02월 20일 19:54, Dan Carpenter wrote:
> of_iomap() doesn't return error pointers, it returns NULL on error.
Applied.
Thanks,
Inki Dae
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> index 63f02e2..9700461 100644
> --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> @@ -888,8 +888,8 @@ static int decon_probe(struct platform_device *pdev)
> of_node_put(i80_if_timings);
>
> ctx->regs = of_iomap(dev->of_node, 0);
> - if (IS_ERR(ctx->regs)) {
> - ret = PTR_ERR(ctx->regs);
> + if (!ctx->regs) {
> + ret = -ENOMEM;
> goto err_del_component;
> }
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-06 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 10:54 [patch] drm/exynos: IS_ERR() vs NULL bug Dan Carpenter
2015-02-20 13:12 ` Gustavo Padovan
2015-03-06 12:49 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.