* [meta-oe][PATCH v3] mplayer2: Remove blacklist
@ 2015-02-13 0:54 Gary Thomas
2015-02-13 1:08 ` Martin Jansa
0 siblings, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2015-02-13 0:54 UTC (permalink / raw)
To: openembedded-devel; +Cc: Gary Thomas
mplayer2 no longer needs to be blacklisted as OE-core has moved
to libav_9.16.
[v2-v3] Also update build dependencies to quash QA warnings, using
PACKAGECONFIG for most optional features.
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 7c04ff1..2de26b0 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -3,7 +3,7 @@ SECTION = "multimedia"
HOMEPAGE = "http://www.mplayerhq.hu/"
DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
- libxv virtual/libx11 libass speex faad2"
+ libxv virtual/libx11 libass speex faad2 libxscrnsaver"
RDEPENDS_${PN} = "mplayer-common"
PROVIDES = "mplayer"
@@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
LICENSE = "GPLv3"
LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
-PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
-
SRC_URI = "git://repo.or.cz/mplayer.git \
file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
"
@@ -109,9 +107,14 @@ EXTRA_OECONF = " \
EXTRA_OECONF_append_armv6 = " --enable-armv6"
EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
+PACKAGECONFIG ??= "vorbis postproc"
PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
PACKAGECONFIG[lame] = ",,lame"
+PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
+PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
+PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
+PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-13 0:54 [meta-oe][PATCH v3] mplayer2: Remove blacklist Gary Thomas
@ 2015-02-13 1:08 ` Martin Jansa
2015-02-13 2:01 ` Gary Thomas
0 siblings, 1 reply; 8+ messages in thread
From: Martin Jansa @ 2015-02-13 1:08 UTC (permalink / raw)
To: openembedded-devel; +Cc: Gary Thomas
Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it
should specify them as well (advantage at least in some projects is that
when it explicitly asking for foo and foo is unusable it will end with
fatal error instead of ignoring broken foo dependency.
On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> mplayer2 no longer needs to be blacklisted as OE-core has moved
> to libav_9.16.
>
> [v2-v3] Also update build dependencies to quash QA warnings, using
> PACKAGECONFIG for most optional features.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index 7c04ff1..2de26b0 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -3,7 +3,7 @@ SECTION = "multimedia"
> HOMEPAGE = "http://www.mplayerhq.hu/"
> DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
> libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
> - libxv virtual/libx11 libass speex faad2"
> + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
>
> RDEPENDS_${PN} = "mplayer-common"
> PROVIDES = "mplayer"
> @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
> LICENSE = "GPLv3"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
>
> -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
> -
> SRC_URI = "git://repo.or.cz/mplayer.git \
>
> file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
> "
> @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
> EXTRA_OECONF_append_armv6 = " --enable-armv6"
> EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>
> +PACKAGECONFIG ??= "vorbis postproc"
> PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
> PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
> PACKAGECONFIG[lame] = ",,lame"
> +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
> +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
> +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
> +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
>
> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer
> -frename-registers -O4 -ffast-math"
> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-13 1:08 ` Martin Jansa
@ 2015-02-13 2:01 ` Gary Thomas
2015-02-20 13:43 ` Martin Jansa
0 siblings, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2015-02-13 2:01 UTC (permalink / raw)
To: Martin Jansa, openembedded-devel
On 2015-02-12 18:08, Martin Jansa wrote:
> Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
> foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.
No, those are auto-discover and only have disable options.
>
> On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>
> mplayer2 no longer needs to be blacklisted as OE-core has moved
> to libav_9.16.
>
> [v2-v3] Also update build dependencies to quash QA warnings, using
> PACKAGECONFIG for most optional features.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
> ---
> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> index 7c04ff1..2de26b0 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> @@ -3,7 +3,7 @@ SECTION = "multimedia"
> HOMEPAGE = "http://www.mplayerhq.hu/"
> DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
> libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
> - libxv virtual/libx11 libass speex faad2"
> + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
>
> RDEPENDS_${PN} = "mplayer-common"
> PROVIDES = "mplayer"
> @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
> LICENSE = "GPLv3"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
>
> -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
> -
> SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
> file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
> "
> @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
> EXTRA_OECONF_append_armv6 = " --enable-armv6"
> EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>
> +PACKAGECONFIG ??= "vorbis postproc"
> PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
> PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
> PACKAGECONFIG[lame] = ",,lame"
> +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
> +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
> +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
> +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
>
> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-13 2:01 ` Gary Thomas
@ 2015-02-20 13:43 ` Martin Jansa
2015-02-20 14:02 ` Gary Thomas
0 siblings, 1 reply; 8+ messages in thread
From: Martin Jansa @ 2015-02-20 13:43 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 4380 bytes --]
On Thu, Feb 12, 2015 at 07:01:17PM -0700, Gary Thomas wrote:
> On 2015-02-12 18:08, Martin Jansa wrote:
> > Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
> > foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.
>
> No, those are auto-discover and only have disable options.
Please add REQUIRED_DISTRO_FEATURES = "x11"
because it depends on couple of recipes which aren't available without
x11: xsp, libxv, virtual/libx11, libxscrnsaver
and it should set LICENSE_FLAGS like libpostproc has to resolve:
ERROR: Nothing PROVIDES 'libpostproc' (but meta-oe/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb DEPENDS on or otherwise requires it)
ERROR: libpostproc was skipped: because it has a restricted license not whitelisted in LICENSE_FLAGS_WHITELIST
> > On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
> >
> > mplayer2 no longer needs to be blacklisted as OE-core has moved
> > to libav_9.16.
> >
> > [v2-v3] Also update build dependencies to quash QA warnings, using
> > PACKAGECONFIG for most optional features.
> >
> > Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
> > ---
> > meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> > index 7c04ff1..2de26b0 100644
> > --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> > +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> > @@ -3,7 +3,7 @@ SECTION = "multimedia"
> > HOMEPAGE = "http://www.mplayerhq.hu/"
> > DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
> > libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
> > - libxv virtual/libx11 libass speex faad2"
> > + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
> >
> > RDEPENDS_${PN} = "mplayer-common"
> > PROVIDES = "mplayer"
> > @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
> > LICENSE = "GPLv3"
> > LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
> >
> > -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
> > -
> > SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
> > file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
> > "
> > @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
> > EXTRA_OECONF_append_armv6 = " --enable-armv6"
> > EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
> >
> > +PACKAGECONFIG ??= "vorbis postproc"
> > PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
> > PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
> > PACKAGECONFIG[lame] = ",,lame"
> > +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
> > +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
> > +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
> > +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
> >
> > FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
> > BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
>
> --
> ------------------------------------------------------------
> Gary Thomas | Consulting for the
> MLB Associates | Embedded world
> ------------------------------------------------------------
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-20 13:43 ` Martin Jansa
@ 2015-02-20 14:02 ` Gary Thomas
2015-02-20 14:34 ` Martin Jansa
0 siblings, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2015-02-20 14:02 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
On 2015-02-20 06:43, Martin Jansa wrote:
> On Thu, Feb 12, 2015 at 07:01:17PM -0700, Gary Thomas wrote:
>> On 2015-02-12 18:08, Martin Jansa wrote:
>>> Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
>>> foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.
>>
>> No, those are auto-discover and only have disable options.
>
> Please add REQUIRED_DISTRO_FEATURES = "x11"
> because it depends on couple of recipes which aren't available without
> x11: xsp, libxv, virtual/libx11, libxscrnsaver
>
> and it should set LICENSE_FLAGS like libpostproc has to resolve:
> ERROR: Nothing PROVIDES 'libpostproc' (but meta-oe/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb DEPENDS on or otherwise requires it)
> ERROR: libpostproc was skipped: because it has a restricted license not whitelisted in LICENSE_FLAGS_WHITELIST
Is there a way to make these conditional? For example, you could build
without libpostproc and the result would not need the commercial license.
There may also be a way to build without X11, but I've not investigated
that yet.
>
>>> On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>>>
>>> mplayer2 no longer needs to be blacklisted as OE-core has moved
>>> to libav_9.16.
>>>
>>> [v2-v3] Also update build dependencies to quash QA warnings, using
>>> PACKAGECONFIG for most optional features.
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
>>> ---
>>> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>> index 7c04ff1..2de26b0 100644
>>> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>> @@ -3,7 +3,7 @@ SECTION = "multimedia"
>>> HOMEPAGE = "http://www.mplayerhq.hu/"
>>> DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
>>> libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
>>> - libxv virtual/libx11 libass speex faad2"
>>> + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
>>>
>>> RDEPENDS_${PN} = "mplayer-common"
>>> PROVIDES = "mplayer"
>>> @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
>>> LICENSE = "GPLv3"
>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
>>>
>>> -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
>>> -
>>> SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
>>> file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
>>> "
>>> @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
>>> EXTRA_OECONF_append_armv6 = " --enable-armv6"
>>> EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>>>
>>> +PACKAGECONFIG ??= "vorbis postproc"
>>> PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>>> PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
>>> PACKAGECONFIG[lame] = ",,lame"
>>> +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
>>> +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
>>> +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
>>> +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
>>>
>>> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
>>> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
>>> --
>>> 1.9.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>>
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas | Consulting for the
>> MLB Associates | Embedded world
>> ------------------------------------------------------------
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-20 14:02 ` Gary Thomas
@ 2015-02-20 14:34 ` Martin Jansa
2015-02-20 14:39 ` Gary Thomas
0 siblings, 1 reply; 8+ messages in thread
From: Martin Jansa @ 2015-02-20 14:34 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 5341 bytes --]
On Fri, Feb 20, 2015 at 07:02:22AM -0700, Gary Thomas wrote:
> On 2015-02-20 06:43, Martin Jansa wrote:
> > On Thu, Feb 12, 2015 at 07:01:17PM -0700, Gary Thomas wrote:
> >> On 2015-02-12 18:08, Martin Jansa wrote:
> >>> Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
> >>> foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.
> >>
> >> No, those are auto-discover and only have disable options.
> >
> > Please add REQUIRED_DISTRO_FEATURES = "x11"
> > because it depends on couple of recipes which aren't available without
> > x11: xsp, libxv, virtual/libx11, libxscrnsaver
> >
> > and it should set LICENSE_FLAGS like libpostproc has to resolve:
> > ERROR: Nothing PROVIDES 'libpostproc' (but meta-oe/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb DEPENDS on or otherwise requires it)
> > ERROR: libpostproc was skipped: because it has a restricted license not whitelisted in LICENSE_FLAGS_WHITELIST
>
> Is there a way to make these conditional? For example, you could build
> without libpostproc and the result would not need the commercial license.
> There may also be a way to build without X11, but I've not investigated
> that yet.
You have added postproc to default PACKAGECONFIG, I haven't tried if it
works without it. The same for x11 related dependencies.
> >>> On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
> >>>
> >>> mplayer2 no longer needs to be blacklisted as OE-core has moved
> >>> to libav_9.16.
> >>>
> >>> [v2-v3] Also update build dependencies to quash QA warnings, using
> >>> PACKAGECONFIG for most optional features.
> >>>
> >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
> >>> ---
> >>> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
> >>> 1 file changed, 6 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> >>> index 7c04ff1..2de26b0 100644
> >>> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> >>> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
> >>> @@ -3,7 +3,7 @@ SECTION = "multimedia"
> >>> HOMEPAGE = "http://www.mplayerhq.hu/"
> >>> DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
> >>> libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
> >>> - libxv virtual/libx11 libass speex faad2"
> >>> + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
> >>>
> >>> RDEPENDS_${PN} = "mplayer-common"
> >>> PROVIDES = "mplayer"
> >>> @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
> >>> LICENSE = "GPLv3"
> >>> LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
> >>>
> >>> -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
> >>> -
> >>> SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
> >>> file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
> >>> "
> >>> @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
> >>> EXTRA_OECONF_append_armv6 = " --enable-armv6"
> >>> EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
> >>>
> >>> +PACKAGECONFIG ??= "vorbis postproc"
> >>> PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
> >>> PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
> >>> PACKAGECONFIG[lame] = ",,lame"
> >>> +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
> >>> +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
> >>> +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
> >>> +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
> >>>
> >>> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
> >>> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
> >>> --
> >>> 1.9.1
> >>>
> >>> --
> >>> _______________________________________________
> >>> Openembedded-devel mailing list
> >>> Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
> >>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>>
> >>>
> >>
> >> --
> >> ------------------------------------------------------------
> >> Gary Thomas | Consulting for the
> >> MLB Associates | Embedded world
> >> ------------------------------------------------------------
> >
>
> --
> ------------------------------------------------------------
> Gary Thomas | Consulting for the
> MLB Associates | Embedded world
> ------------------------------------------------------------
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [meta-oe][PATCH v3] mplayer2: Remove blacklist
2015-02-20 14:34 ` Martin Jansa
@ 2015-02-20 14:39 ` Gary Thomas
2015-03-05 14:30 ` [meta-oe][PATCH] mplayer2: set REQUIRED_DISTRO_FEATURES and LICENSE_FLAGS Martin Jansa
0 siblings, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2015-02-20 14:39 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
On 2015-02-20 07:34, Martin Jansa wrote:
> On Fri, Feb 20, 2015 at 07:02:22AM -0700, Gary Thomas wrote:
>> On 2015-02-20 06:43, Martin Jansa wrote:
>>> On Thu, Feb 12, 2015 at 07:01:17PM -0700, Gary Thomas wrote:
>>>> On 2015-02-12 18:08, Martin Jansa wrote:
>>>>> Does it have --enable-* options for the new PACKAGECONFIGs? If yes then it should specify them as well (advantage at least in some projects is that when it explicitly asking for
>>>>> foo and foo is unusable it will end with fatal error instead of ignoring broken foo dependency.
>>>>
>>>> No, those are auto-discover and only have disable options.
>>>
>>> Please add REQUIRED_DISTRO_FEATURES = "x11"
>>> because it depends on couple of recipes which aren't available without
>>> x11: xsp, libxv, virtual/libx11, libxscrnsaver
>>>
>>> and it should set LICENSE_FLAGS like libpostproc has to resolve:
>>> ERROR: Nothing PROVIDES 'libpostproc' (but meta-oe/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb DEPENDS on or otherwise requires it)
>>> ERROR: libpostproc was skipped: because it has a restricted license not whitelisted in LICENSE_FLAGS_WHITELIST
>>
>> Is there a way to make these conditional? For example, you could build
>> without libpostproc and the result would not need the commercial license.
>> There may also be a way to build without X11, but I've not investigated
>> that yet.
>
> You have added postproc to default PACKAGECONFIG, I haven't tried if it
> works without it. The same for x11 related dependencies.
The question was is there a way to not set the license as commercial
if libpostproc is disabled?
>
>>>>> On Fri, Feb 13, 2015 at 1:54 AM, Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>> wrote:
>>>>>
>>>>> mplayer2 no longer needs to be blacklisted as OE-core has moved
>>>>> to libav_9.16.
>>>>>
>>>>> [v2-v3] Also update build dependencies to quash QA warnings, using
>>>>> PACKAGECONFIG for most optional features.
>>>>>
>>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com <mailto:gary@mlbassoc.com>>
>>>>> ---
>>>>> meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> | 9 ++++++---
>>>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb> b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>>>> index 7c04ff1..2de26b0 100644
>>>>> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>>>> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb <http://mplayer2_git.bb>
>>>>> @@ -3,7 +3,7 @@ SECTION = "multimedia"
>>>>> HOMEPAGE = "http://www.mplayerhq.hu/"
>>>>> DEPENDS = "libvpx libdvdread libtheora virtual/libsdl ffmpeg xsp zlib \
>>>>> libpng jpeg liba52 freetype fontconfig alsa-lib lzo ncurses \
>>>>> - libxv virtual/libx11 libass speex faad2"
>>>>> + libxv virtual/libx11 libass speex faad2 libxscrnsaver"
>>>>>
>>>>> RDEPENDS_${PN} = "mplayer-common"
>>>>> PROVIDES = "mplayer"
>>>>> @@ -13,8 +13,6 @@ RCONFLICTS_${PN} = "mplayer"
>>>>> LICENSE = "GPLv3"
>>>>> LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
>>>>>
>>>>> -PNBLACKLIST[mplayer2] ?= "Requires newer libav which has negative D_P"
>>>>> -
>>>>> SRC_URI = "git://repo.or.cz/mplayer.git <http://repo.or.cz/mplayer.git> \
>>>>> file://0001-configure-don-t-disable-ASS-support-when-explicitly-.patch \
>>>>> "
>>>>> @@ -109,9 +107,14 @@ EXTRA_OECONF = " \
>>>>> EXTRA_OECONF_append_armv6 = " --enable-armv6"
>>>>> EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>>>>>
>>>>> +PACKAGECONFIG ??= "vorbis postproc"
>>>>> PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>>>>> PACKAGECONFIG[a52] = "--enable-liba52,--disable-liba52,liba52"
>>>>> PACKAGECONFIG[lame] = ",,lame"
>>>>> +PACKAGECONFIG[postproc] = ",--disable-libpostproc,libpostproc"
>>>>> +PACKAGECONFIG[vorbis] = ",--disable-libvorbis,libvorbis"
>>>>> +PACKAGECONFIG[portaudio] = ",--disable-portaudio,portaudio-v19"
>>>>> +PACKAGECONFIG[mpg123] = ",--disable-mpg123,mpg123"
>>>>>
>>>>> FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
>>>>> BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-devel mailing list
>>>>> Openembedded-devel@lists.openembedded.org <mailto:Openembedded-devel@lists.openembedded.org>
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>>>
>>>>>
>>>>
>>>> --
>>>> ------------------------------------------------------------
>>>> Gary Thomas | Consulting for the
>>>> MLB Associates | Embedded world
>>>> ------------------------------------------------------------
>>>
>>
>> --
>> ------------------------------------------------------------
>> Gary Thomas | Consulting for the
>> MLB Associates | Embedded world
>> ------------------------------------------------------------
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* [meta-oe][PATCH] mplayer2: set REQUIRED_DISTRO_FEATURES and LICENSE_FLAGS
2015-02-20 14:39 ` Gary Thomas
@ 2015-03-05 14:30 ` Martin Jansa
0 siblings, 0 replies; 8+ messages in thread
From: Martin Jansa @ 2015-03-05 14:30 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index 2de26b0..8c5f4eb 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -10,6 +10,12 @@ PROVIDES = "mplayer"
RPROVIDES_${PN} = "mplayer"
RCONFLICTS_${PN} = "mplayer"
+# Depends on xsp, libxv, virtual/libx11, libxscrnsaver
+REQUIRED_DISTRO_FEATURES = "x11"
+
+# because it depends on libpostproc/libav which has commercial flag
+LICENSE_FLAGS = "${@base_contains('PACKAGECONFIG', 'postproc', 'commercial', '', d)}"
+
LICENSE = "GPLv3"
LIC_FILES_CHKSUM = "file://LICENSE;md5=d32239bcb673463ab874e80d47fae504"
--
2.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-05 14:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-13 0:54 [meta-oe][PATCH v3] mplayer2: Remove blacklist Gary Thomas
2015-02-13 1:08 ` Martin Jansa
2015-02-13 2:01 ` Gary Thomas
2015-02-20 13:43 ` Martin Jansa
2015-02-20 14:02 ` Gary Thomas
2015-02-20 14:34 ` Martin Jansa
2015-02-20 14:39 ` Gary Thomas
2015-03-05 14:30 ` [meta-oe][PATCH] mplayer2: set REQUIRED_DISTRO_FEATURES and LICENSE_FLAGS Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.