All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael Walle <michael@walle.cc>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings
Date: Fri, 20 Feb 2015 16:43:06 +0100	[thread overview]
Message-ID: <20150220154305.GC18126@potion.brq.redhat.com> (raw)
In-Reply-To: <54E746CE.7020409@redhat.com>

2015-02-20 15:38+0100, Paolo Bonzini:
> On 20/02/2015 15:18, Radim Krčmář wrote:
> > -    if (!!n->vhost_started ==
> > +    if ((!!n->vhost_started) ==
> >          (virtio_net_started(n, status) && !nc->peer->link_down)) {
> 
> Does it still break if you just swap the terms?

No (there is no logical not on left side then), will do that.

  reply	other threads:[~2015-02-20 15:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 14:18 [Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors Radim Krčmář
2015-02-20 14:18 ` [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings Radim Krčmář
2015-02-20 14:38   ` Paolo Bonzini
2015-02-20 15:43     ` Radim Krčmář [this message]
2015-02-20 14:18 ` [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning Radim Krčmář
2015-02-20 14:24   ` Radim Krčmář
2015-02-20 14:36   ` Paolo Bonzini
2015-02-20 14:52     ` Michael Walle
2015-02-20 14:55       ` Paolo Bonzini
2015-02-20 15:48         ` Radim Krčmář
2015-02-20 14:40   ` Peter Maydell
2015-02-20 15:37     ` Radim Krčmář
2015-02-20 16:10       ` Michael Walle
  -- strict thread matches above, loose matches on Subject: below --
2015-02-20 16:06 [Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors Radim Krčmář
2015-02-20 16:06 ` [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings Radim Krčmář
2015-03-04 14:36   ` Michael Tokarev
2015-03-04 16:27     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150220154305.GC18126@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=michael@walle.cc \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.