From: David Cohen <david.a.cohen@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
baolu.lu@linux.intel.com
Subject: Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)
Date: Fri, 20 Feb 2015 11:02:26 -0800 [thread overview]
Message-ID: <20150220190226.GA15303@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1424385546.5308.7.camel@x220>
Hi,
On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > As always, comments are welcome.
>
> Are nits welcome too?
>
> > +MODULE_LICENSE("GPLv2");
>
> You probably meant
> MODULE_LICENSE("GPL v2")
>
> Didn't that trigger a warning or error?
checkpatch showed no warning about that, not even with --strict option.
I believe both ways are fine. But I can add the space.
Br, David
>
>
> Paul Bolle
>
next prev parent reply other threads:[~2015-02-20 19:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 22:43 [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s) David Cohen
2014-12-23 1:25 ` Peter Chen
2014-12-23 19:40 ` David Cohen
2014-12-24 3:08 ` Peter Chen
2014-12-24 22:46 ` David Cohen
2014-12-23 13:10 ` Sergei Shtylyov
2014-12-23 19:57 ` David Cohen
2014-12-23 20:09 ` Sergei Shtylyov
2014-12-23 20:43 ` David Cohen
2014-12-24 0:29 ` Felipe Balbi
2014-12-24 22:43 ` David Cohen
2014-12-26 4:49 ` Felipe Balbi
2015-02-17 19:18 ` David Cohen
2015-02-17 19:25 ` Felipe Balbi
2015-02-17 19:35 ` David Cohen
2015-02-18 10:17 ` Mika Westerberg
2015-02-18 17:53 ` David Cohen
2015-01-08 19:23 ` Linus Walleij
2015-02-17 19:20 ` David Cohen
2015-02-19 19:59 ` [PATCH v2] " David Cohen
2015-02-19 22:39 ` Paul Bolle
2015-02-20 19:02 ` David Cohen [this message]
2015-02-20 19:09 ` Felipe Balbi
2015-02-20 19:18 ` David Cohen
2015-02-20 19:10 ` Paul Bolle
2015-02-20 19:18 ` David Cohen
2015-02-20 6:41 ` Robert Baldyga
2015-02-20 9:53 ` Linus Walleij
2015-02-20 19:17 ` David Cohen
2015-02-20 19:36 ` Felipe Balbi
2015-02-20 19:59 ` David Cohen
2015-02-20 20:00 ` Felipe Balbi
2015-02-20 20:40 ` David Cohen
2015-03-07 20:03 ` Linus Walleij
2015-02-24 19:18 ` David Cohen
2015-03-07 20:06 ` Linus Walleij
2015-03-09 16:16 ` Felipe Balbi
2015-03-09 19:10 ` David Cohen
2015-03-16 16:46 ` David Cohen
2015-03-16 16:46 ` David Cohen
2015-03-19 8:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220190226.GA15303@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.