[PATCH] Staging: rtl8188eu: Remove unnecessary variable

[PATCH] Staging: rtl8188eu: Remove unnecessary variable

[Vatika Harlalka]

Remove unnecessary variable and replace its uses with previously
defined variable.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/rtl8188eu/hal/phy.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
index 623fb4f..341f0db 100644
--- a/drivers/staging/rtl8188eu/hal/phy.c
+++ b/drivers/staging/rtl8188eu/hal/phy.c
@@ -117,10 +117,9 @@ static void rf_serial_write(struct adapter *adapt,
 	u32 data_and_addr = 0;
 	struct hal_data_8188e *hal_data = GET_HAL_DATA(adapt);
 	struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath];
-	u32 newoffset;
 
-	newoffset = offset & 0xff;
-	data_and_addr = ((newoffset<<20) | (data&0x000fffff)) & 0x0fffffff;
+	offset &= 0xff;
+	data_and_addr = ((offset<<20) | (data&0x000fffff)) & 0x0fffffff;
 	phy_set_bb_reg(adapt, phyreg->rf3wireOffset, bMaskDWord, data_and_addr);
 }
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove unnecessary variable

[Daniel Baluta]

On Mon, Feb 23, 2015 at 11:16 AM, Vatika Harlalka
<vatikaharlalka@gmail.com> wrote:
> Remove unnecessary variable and replace its uses with previously
> defined variable.

Hi Vatika,

A good commit message should always try to explain why the change is needed.
In this case you could say:

We only need the last 8 bits from offset, so we can directly operate
on offset variable
instead of introducing unneeded newoffset.

Other than that the code looks good to me.

Thanks,
Daniel.

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove unnecessary variable

[Julia Lawall]

On Mon, 23 Feb 2015, Daniel Baluta wrote:

> On Mon, Feb 23, 2015 at 11:16 AM, Vatika Harlalka
> <vatikaharlalka@gmail.com> wrote:
> > Remove unnecessary variable and replace its uses with previously
> > defined variable.
>
> Hi Vatika,
>
> A good commit message should always try to explain why the change is needed.
> In this case you could say:
>
> We only need the last 8 bits from offset, so we can directly operate
> on offset variable
> instead of introducing unneeded newoffset.

How is the number of bits used relevant?  They are both u32 variables.

thanks,
julia

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Remove unnecessary variable

[Daniel Baluta]

On Mon, Feb 23, 2015 at 11:41 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> On Mon, 23 Feb 2015, Daniel Baluta wrote:
>
>> On Mon, Feb 23, 2015 at 11:16 AM, Vatika Harlalka
>> <vatikaharlalka@gmail.com> wrote:
>> > Remove unnecessary variable and replace its uses with previously
>> > defined variable.
>>
>> Hi Vatika,
>>
>> A good commit message should always try to explain why the change is needed.
>> In this case you could say:
>>
>> We only need the last 8 bits from offset, so we can directly operate
>> on offset variable
>> instead of introducing unneeded newoffset.
>
> How is the number of bits used relevant?  They are both u32 variables.

Used as in useful.

Doing:

newoffset = offset & 0xff;

we only care about last 8 bits of offset.

Daniel.

[PATCH] Staging: rtl8188eu: Remove unnecessary variable

[Vatika Harlalka]

Remove unneccessary variable and replace its uses with another
variable which is previously defined.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/rtl8188eu/hal/phy.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
index 3f663fe..3950cb3 100644
--- a/drivers/staging/rtl8188eu/hal/phy.c
+++ b/drivers/staging/rtl8188eu/hal/phy.c
@@ -72,12 +72,10 @@ static u32 rf_serial_read(struct adapter *adapt,
 	u32 ret = 0;
 	struct hal_data_8188e *hal_data = GET_HAL_DATA(adapt);
 	struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath];
-	u32 newoffset;
 	u32 tmplong, tmplong2;
 	u8 rfpi_enable = 0;
 
 	offset &= 0xff;
-	newoffset = offset;
 
 	tmplong = phy_query_bb_reg(adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord);
 	if (rfpath == RF_PATH_A)
@@ -87,7 +85,7 @@ static u32 rf_serial_read(struct adapter *adapt,
 					    bMaskDWord);
 
 	tmplong2 = (tmplong2 & (~bLSSIReadAddress)) |
-		   (newoffset<<23) | bLSSIReadEdge;
+		   (offset<<23) | bLSSIReadEdge;
 
 	phy_set_bb_reg(adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord,
 		       tmplong&(~bLSSIReadEdge));
-- 
1.9.1