[PATCH v2] Staging: rtl8188eu: Remove unused variable

[PATCH v2] Staging: rtl8188eu: Remove unused variable

[Vatika Harlalka]

We only need the last 8 bits of the offset variable so we can
directly operate on it instead of introducing unneeded
newoffset variable.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 Changes in v2: Changed commit message to make it more descriptive.

 drivers/staging/rtl8188eu/hal/phy.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
index 623fb4f..341f0db 100644
--- a/drivers/staging/rtl8188eu/hal/phy.c
+++ b/drivers/staging/rtl8188eu/hal/phy.c
@@ -117,10 +117,9 @@ static void rf_serial_write(struct adapter *adapt,
 	u32 data_and_addr = 0;
 	struct hal_data_8188e *hal_data = GET_HAL_DATA(adapt);
 	struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath];
-	u32 newoffset;
 
-	newoffset = offset & 0xff;
-	data_and_addr = ((newoffset<<20) | (data&0x000fffff)) & 0x0fffffff;
+	offset &= 0xff;
+	data_and_addr = ((offset<<20) | (data&0x000fffff)) & 0x0fffffff;
 	phy_set_bb_reg(adapt, phyreg->rf3wireOffset, bMaskDWord, data_and_addr);
 }
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2] Staging: rtl8188eu: Remove unused variable

[Daniel Baluta]

On Mon, Feb 23, 2015 at 11:41 AM, Vatika Harlalka
<vatikaharlalka@gmail.com> wrote:
> We only need the last 8 bits of the offset variable so we can
> directly operate on it instead of introducing unneeded
> newoffset variable.
>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

Re: [Outreachy kernel] [PATCH v2] Staging: rtl8188eu: Remove unused variable

[Jes Sorensen]

On 02/23/15 04:41, Vatika Harlalka wrote:
> We only need the last 8 bits of the offset variable so we can
> directly operate on it instead of introducing unneeded
> newoffset variable.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  Changes in v2: Changed commit message to make it more descriptive.
> 
>  drivers/staging/rtl8188eu/hal/phy.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
> index 623fb4f..341f0db 100644
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -117,10 +117,9 @@ static void rf_serial_write(struct adapter *adapt,
>  	u32 data_and_addr = 0;
>  	struct hal_data_8188e *hal_data = GET_HAL_DATA(adapt);
>  	struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath];
> -	u32 newoffset;
>  
> -	newoffset = offset & 0xff;
> -	data_and_addr = ((newoffset<<20) | (data&0x000fffff)) & 0x0fffffff;
> +	offset &= 0xff;
> +	data_and_addr = ((offset<<20) | (data&0x000fffff)) & 0x0fffffff;

Fix is good, but you need to comply with the space rules as well when
you do this. It should say:

	data_and_addr = ((offset << 20) | (data & 0x000fffff)) & 0x0fffffff;

Cheers,
Jes

>  	phy_set_bb_reg(adapt, phyreg->rf3wireOffset, bMaskDWord, data_and_addr);
>  }
>  
>