From: Bjorn Helgaas <bhelgaas@google.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: linux-pci@vger.kernel.org, phil.edworthy@renesas.com,
horms+renesas@verge.net.au
Subject: Re: [PATCH] PCI: rcar: Fix postion of MSI enable bit
Date: Mon, 23 Feb 2015 19:22:36 -0600 [thread overview]
Message-ID: <20150224012236.GA6220@google.com> (raw)
In-Reply-To: <1422853779-14413-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Mon, Feb 02, 2015 at 02:09:39PM +0900, Nobuhiro Iwamatsu wrote:
> Position of MSI enable bit is 31bit, not 28bit.
> This fixes position of MSI bit necessary to initialize MSI.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied to pci/host-rcar for v4.1, thanks!
> ---
> drivers/pci/host/pcie-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index bb36e27..eb12659 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
>
> /* Enable MSI */
> if (IS_ENABLED(CONFIG_PCI_MSI))
> - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
> + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
>
> /* Finish initialization - establish a PCI Express link */
> rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
> --
> 2.1.3
>
next prev parent reply other threads:[~2015-02-24 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 5:09 [PATCH] PCI: rcar: Fix postion of MSI enable bit Nobuhiro Iwamatsu
2015-02-24 1:22 ` Bjorn Helgaas [this message]
2015-02-24 1:57 ` Simon Horman
[not found] <1422853483-14334-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
2015-02-03 18:46 ` Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224012236.GA6220@google.com \
--to=bhelgaas@google.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.