* [PATCH] PCI: rcar: Fix postion of MSI enable bit
@ 2015-02-02 5:09 Nobuhiro Iwamatsu
2015-02-24 1:22 ` Bjorn Helgaas
2015-02-24 1:57 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2015-02-02 5:09 UTC (permalink / raw)
To: bhelgaas; +Cc: linux-pci, phil.edworthy, horms+renesas, Nobuhiro Iwamatsu
Position of MSI enable bit is 31bit, not 28bit.
This fixes position of MSI bit necessary to initialize MSI.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
drivers/pci/host/pcie-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index bb36e27..eb12659 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
/* Enable MSI */
if (IS_ENABLED(CONFIG_PCI_MSI))
- rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
+ rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
/* Finish initialization - establish a PCI Express link */
rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] PCI: rcar: Fix postion of MSI enable bit
[not found] <1422853483-14334-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
@ 2015-02-03 18:46 ` Phil Edworthy
0 siblings, 0 replies; 4+ messages in thread
From: Phil Edworthy @ 2015-02-03 18:46 UTC (permalink / raw)
To: Nobuhiro Iwamatsu
Cc: linux-pci@vger.kernel.org, horms+renesas@verge.net.au,
Nobuhiro Iwamatsu, bhelgaas@google.com
Resend with correct ml address
On: 03 February 2015 18:44, Phil Edworthy wrote:
> Hi Iwamatsu-san,
>
> Hmm, this is odd as MSI works before and after your patch. Since bit 31 just
> represents the value of MSICAP0[16].MSIE, I think this may just be used for
> endpoints.
>
> However, you are correct that the bit used was wrong and so:
> Acked-by: Phil Edworthy <phil.edworthy@renesas.com>
>
> Thanks
> Phil
>
> On: 02 February 2015 05:05, Nobuhiro Iwamatsu wrote:
> >
> > Position of MSI enable bit is 31bit, not 28bit.
> > This fixes position of MSI bit necessary to initialize MSI.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > ---
> > drivers/pci/host/pcie-rcar.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> > index bb36e27..eb12659 100644
> > --- a/drivers/pci/host/pcie-rcar.c
> > +++ b/drivers/pci/host/pcie-rcar.c
> > @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
> >
> > /* Enable MSI */
> > if (IS_ENABLED(CONFIG_PCI_MSI))
> > - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
> > + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
> >
> > /* Finish initialization - establish a PCI Express link */
> > rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
> > --
> > 2.1.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar: Fix postion of MSI enable bit
2015-02-02 5:09 [PATCH] PCI: rcar: Fix postion of MSI enable bit Nobuhiro Iwamatsu
@ 2015-02-24 1:22 ` Bjorn Helgaas
2015-02-24 1:57 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2015-02-24 1:22 UTC (permalink / raw)
To: Nobuhiro Iwamatsu; +Cc: linux-pci, phil.edworthy, horms+renesas
On Mon, Feb 02, 2015 at 02:09:39PM +0900, Nobuhiro Iwamatsu wrote:
> Position of MSI enable bit is 31bit, not 28bit.
> This fixes position of MSI bit necessary to initialize MSI.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Applied to pci/host-rcar for v4.1, thanks!
> ---
> drivers/pci/host/pcie-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index bb36e27..eb12659 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
>
> /* Enable MSI */
> if (IS_ENABLED(CONFIG_PCI_MSI))
> - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
> + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
>
> /* Finish initialization - establish a PCI Express link */
> rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: rcar: Fix postion of MSI enable bit
2015-02-02 5:09 [PATCH] PCI: rcar: Fix postion of MSI enable bit Nobuhiro Iwamatsu
2015-02-24 1:22 ` Bjorn Helgaas
@ 2015-02-24 1:57 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2015-02-24 1:57 UTC (permalink / raw)
To: Nobuhiro Iwamatsu; +Cc: bhelgaas, linux-pci, phil.edworthy
On Mon, Feb 02, 2015 at 02:09:39PM +0900, Nobuhiro Iwamatsu wrote:
> Position of MSI enable bit is 31bit, not 28bit.
> This fixes position of MSI bit necessary to initialize MSI.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/pci/host/pcie-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> index bb36e27..eb12659 100644
> --- a/drivers/pci/host/pcie-rcar.c
> +++ b/drivers/pci/host/pcie-rcar.c
> @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie)
>
> /* Enable MSI */
> if (IS_ENABLED(CONFIG_PCI_MSI))
> - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR);
> + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR);
>
> /* Finish initialization - establish a PCI Express link */
> rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR);
> --
> 2.1.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-24 1:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-02 5:09 [PATCH] PCI: rcar: Fix postion of MSI enable bit Nobuhiro Iwamatsu
2015-02-24 1:22 ` Bjorn Helgaas
2015-02-24 1:57 ` Simon Horman
[not found] <1422853483-14334-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
2015-02-03 18:46 ` Phil Edworthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.