* [PATCH] Staging: bcm: Remove space before tab
@ 2015-02-21 19:45 Yeliz Taneroglu
2015-02-21 22:28 ` [Outreachy kernel] " Arnd Bergmann
2015-02-24 7:42 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Yeliz Taneroglu @ 2015-02-21 19:45 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Yeliz Taneroglu
This patch fixes the checkpatch.pl warning:
WARNING: "please, no space before tabs"
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h
index 6f3270c..a7d4af5 100644
--- a/drivers/staging/bcm/headers.h
+++ b/drivers/staging/bcm/headers.h
@@ -1,6 +1,6 @@
/*******************************************************************
-* Headers.h
+* Headers.h
*******************************************************************/
#ifndef __HEADERS_H__
#define __HEADERS_H__
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: bcm: Remove space before tab
2015-02-21 19:45 [PATCH] Staging: bcm: Remove space before tab Yeliz Taneroglu
@ 2015-02-21 22:28 ` Arnd Bergmann
2015-02-24 7:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-02-21 22:28 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Yeliz Taneroglu
On Saturday 21 February 2015 21:45:56 Yeliz Taneroglu wrote:
> --- a/drivers/staging/bcm/headers.h
> +++ b/drivers/staging/bcm/headers.h
> @@ -1,6 +1,6 @@
>
> /*******************************************************************
> -* Headers.h
> +* Headers.h
> *******************************************************************/
> #ifndef __HEADERS_H__
> #define __HEADERS_H__
It may be better to drop the comment entirely. We normally don't put the
file name into comments, because files tend to get renamed a lot, making
the comment incorrect, and because it's entirely redundant.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: bcm: Remove space before tab
2015-02-21 19:45 [PATCH] Staging: bcm: Remove space before tab Yeliz Taneroglu
2015-02-21 22:28 ` [Outreachy kernel] " Arnd Bergmann
@ 2015-02-24 7:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-02-24 7:42 UTC (permalink / raw)
To: Yeliz Taneroglu; +Cc: outreachy-kernel
On Sat, Feb 21, 2015 at 09:45:56PM +0200, Yeliz Taneroglu wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: "please, no space before tabs"
>
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
> drivers/staging/bcm/headers.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h
> index 6f3270c..a7d4af5 100644
> --- a/drivers/staging/bcm/headers.h
> +++ b/drivers/staging/bcm/headers.h
> @@ -1,6 +1,6 @@
>
> /*******************************************************************
> -* Headers.h
> +* Headers.h
> *******************************************************************/
> #ifndef __HEADERS_H__
> #define __HEADERS_H__
This driver is not in the tree at all, so I have to just delete all of
the patches you made against it, sorry.
Please work off of linux-next, or my staging-next branch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-24 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21 19:45 [PATCH] Staging: bcm: Remove space before tab Yeliz Taneroglu
2015-02-21 22:28 ` [Outreachy kernel] " Arnd Bergmann
2015-02-24 7:42 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.