Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU

[Igor Mammedov <imammedo@redhat.com>]

On Thu, 12 Feb 2015 15:50:35 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> Instead of silently assigning CPU to node 0 when it is omitted from the
> command-line, check if all CPUs up to max_cpus are present in the NUMA
> configuration.
That would also trigger warning for possible (i.e. to be hotplugged) CPUs
as well.

> 
> I am making this a warning and not a fatal error, to allow management
> software to be updated if necessary.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> v1 -> v2: (no changes)
> 
> v2 -> v3:
>  * Use enumerate_cpus() and error_report() for error message
>  * Simplify logic using bitmap_full()
> ---
>  numa.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/numa.c b/numa.c
> index 712faff..4310bf9 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -201,6 +201,14 @@ static void validate_numa_cpus(void)
>          bitmap_or(seen_cpus, seen_cpus,
>                    numa_info[i].node_cpu, MAX_CPUMASK_BITS);
>      }
> +
> +    if (!bitmap_full(seen_cpus, max_cpus)) {
> +        char *msg;
> +        bitmap_complement(seen_cpus, seen_cpus, max_cpus);
> +        msg = enumerate_cpus(seen_cpus, max_cpus);
> +        error_report("warning: CPU(s) not present in any NUMA nodes: %s", msg);
Maybe add to this that all CPUs up to maxcpus must be described in numa config?

> +        g_free(msg);
> +    }
>  }
>  
>  void parse_numa_opts(void)