From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Hu Tao <hutao@cn.fujitsu.com>,
Igor Mammedov <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU
Date: Thu, 12 Feb 2015 19:22:37 +0100 [thread overview]
Message-ID: <54DCEF6D.6080903@redhat.com> (raw)
In-Reply-To: <1423763435-3696-5-git-send-email-ehabkost@redhat.com>
On 12/02/2015 18:50, Eduardo Habkost wrote:
> +
> + if (!bitmap_full(seen_cpus, max_cpus)) {
> + char *msg;
> + bitmap_complement(seen_cpus, seen_cpus, max_cpus);
> + msg = enumerate_cpus(seen_cpus, max_cpus);
> + error_report("warning: CPU(s) not present in any NUMA nodes: %s", msg);
> + g_free(msg);
> + }
What happens if you have a single node (useful to give it a memdev via
-numa node,memdev=...)? It would be nice in this case to avoid the
warning and assign all CPUs to node 0.
Paolo
next prev parent reply other threads:[~2015-02-12 18:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 17:50 [Qemu-devel] [PATCH v3 0/4] NUMA: Validate CPU configuration Eduardo Habkost
2015-02-12 17:50 ` [Qemu-devel] [PATCH v3 1/4] numa: Fix off-by-one error at MAX_CPUMASK_BITS check Eduardo Habkost
2015-02-24 6:38 ` Igor Mammedov
2015-02-12 17:50 ` [Qemu-devel] [PATCH v3 2/4] numa: Reject CPU indexes > max_cpus Eduardo Habkost
2015-02-24 6:49 ` Igor Mammedov
2015-02-12 17:50 ` [Qemu-devel] [PATCH v3 3/4] numa: Reject configuration if CPU appears on multiple nodes Eduardo Habkost
2015-02-24 7:04 ` Igor Mammedov
2015-02-12 17:50 ` [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is assigned to a CPU Eduardo Habkost
2015-02-12 18:22 ` Paolo Bonzini [this message]
2015-02-12 23:05 ` Eduardo Habkost
2015-02-24 8:01 ` Igor Mammedov
2015-02-24 18:19 ` Eduardo Habkost
2015-02-25 8:43 ` Igor Mammedov
2015-02-23 20:10 ` [Qemu-devel] [PATCH v3 0/4] NUMA: Validate CPU configuration Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCEF6D.6080903@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.