[PATCH v3] Staging: media: vino: Add blank line

[PATCH v3] Staging: media: vino: Add blank line

[Ksenija Stanojevic]

This patch fixes the checkpatch.pl warning:
WARNING: "Missing a blank line after declarations"

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
v3: Use of imperative language(add instead of added).
v2: Fixed e-mail address.
 drivers/staging/media/vino/saa7191.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/media/vino/saa7191.c b/drivers/staging/media/vino/saa7191.c
index 29e3296..f223e47 100644
--- a/drivers/staging/media/vino/saa7191.c
+++ b/drivers/staging/media/vino/saa7191.c
@@ -521,6 +521,7 @@ static int saa7191_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
 		break;
 	case SAA7191_CONTROL_LUMA_DELAY: {
 		s32 value = ctrl->value;
+
 		if (value < 0)
 			value += 8;
 		reg = saa7191_read_reg(sd, SAA7191_REG_CTL3);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v3] Staging: media: vino: Add blank line

[Julia Lawall]

On Thu, 19 Feb 2015, Ksenija Stanojevic wrote:

> This patch fixes the checkpatch.pl warning:
> WARNING: "Missing a blank line after declarations"
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v3: Use of imperative language(add instead of added).

The subject line looks better.  Don't send a patch for this, because it is 
below the --- so it doesn't matter, but there should be a space before the 
( in this message.

julia

> v2: Fixed e-mail address.
>  drivers/staging/media/vino/saa7191.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/vino/saa7191.c b/drivers/staging/media/vino/saa7191.c
> index 29e3296..f223e47 100644
> --- a/drivers/staging/media/vino/saa7191.c
> +++ b/drivers/staging/media/vino/saa7191.c
> @@ -521,6 +521,7 @@ static int saa7191_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl)
>  		break;
>  	case SAA7191_CONTROL_LUMA_DELAY: {
>  		s32 value = ctrl->value;
> +
>  		if (value < 0)
>  			value += 8;
>  		reg = saa7191_read_reg(sd, SAA7191_REG_CTL3);
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424379952-21236-1-git-send-email-ksenija.stanojevic%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v3] Staging: media: vino: Add blank line

[Greg KH]

On Thu, Feb 19, 2015 at 10:05:52PM +0100, Ksenija Stanojevic wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: "Missing a blank line after declarations"
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v3: Use of imperative language(add instead of added).
> v2: Fixed e-mail address.
>  drivers/staging/media/vino/saa7191.c | 1 +

This file is no longer in the tree, so I can't accept a patch for it,
sorry :(