From: Greg KH <gregkh@linuxfoundation.org>
To: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Fixed else after return or break warning
Date: Tue, 24 Feb 2015 15:28:23 -0800 [thread overview]
Message-ID: <20150224232823.GA25121@kroah.com> (raw)
In-Reply-To: <1424552476-6232-1-git-send-email-yeliztaneroglu@gmail.com>
On Sat, Feb 21, 2015 at 11:01:16PM +0200, Yeliz Taneroglu wrote:
> The following patch fixes the checkpatch.pl warning:
> drivers/staging/emxx_udc/emxx_udc.c warning: else is not generally useful
> after a break or return
>
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 0351728..36aca56 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -1491,8 +1491,7 @@ static int _nbu2ss_get_ep_stall(struct nbu2ss_udc *udc, u8 ep_adrs)
>
> if ((data & bit_data) == 0)
> return 0;
> - else
> - return 1;
> + return 1;
> }
>
> /*-------------------------------------------------------------------------*/
This fix was already done a while ago, please update your kernel version
so you don't end up redoing work that others did :(
thanks,
greg k-h
prev parent reply other threads:[~2015-02-24 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 21:01 [PATCH] Staging: emxx_udc: Fixed else after return or break warning Yeliz Taneroglu
2015-02-24 23:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224232823.GA25121@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=yeliztaneroglu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.