* [PATCH] Staging: emxx_udc: Fixed else after return or break warning
@ 2015-02-21 21:01 Yeliz Taneroglu
2015-02-24 23:28 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Yeliz Taneroglu @ 2015-02-21 21:01 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Yeliz Taneroglu
The following patch fixes the checkpatch.pl warning:
drivers/staging/emxx_udc/emxx_udc.c warning: else is not generally useful
after a break or return
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0351728..36aca56 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -1491,8 +1491,7 @@ static int _nbu2ss_get_ep_stall(struct nbu2ss_udc *udc, u8 ep_adrs)
if ((data & bit_data) == 0)
return 0;
- else
- return 1;
+ return 1;
}
/*-------------------------------------------------------------------------*/
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Fixed else after return or break warning
2015-02-21 21:01 [PATCH] Staging: emxx_udc: Fixed else after return or break warning Yeliz Taneroglu
@ 2015-02-24 23:28 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-02-24 23:28 UTC (permalink / raw)
To: Yeliz Taneroglu; +Cc: outreachy-kernel
On Sat, Feb 21, 2015 at 11:01:16PM +0200, Yeliz Taneroglu wrote:
> The following patch fixes the checkpatch.pl warning:
> drivers/staging/emxx_udc/emxx_udc.c warning: else is not generally useful
> after a break or return
>
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 0351728..36aca56 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -1491,8 +1491,7 @@ static int _nbu2ss_get_ep_stall(struct nbu2ss_udc *udc, u8 ep_adrs)
>
> if ((data & bit_data) == 0)
> return 0;
> - else
> - return 1;
> + return 1;
> }
>
> /*-------------------------------------------------------------------------*/
This fix was already done a while ago, please update your kernel version
so you don't end up redoing work that others did :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-24 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21 21:01 [PATCH] Staging: emxx_udc: Fixed else after return or break warning Yeliz Taneroglu
2015-02-24 23:28 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.