From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386
Date: Wed, 25 Feb 2015 13:38:46 +0100 [thread overview]
Message-ID: <20150225123845.GA5362@8bytes.org> (raw)
In-Reply-To: <1424111900-23887-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
On Mon, Feb 16, 2015 at 06:38:20PM +0000, Will Deacon wrote:
> Various build/boot bots have reported WARNs being triggered by the ARM
> iopgtable LPAE self-tests on i386 machines.
>
> This boils down to two instances of right-shifting a 32-bit unsigned
> long (i.e. an iova) by more than the size of the type. On 32-bit ARM,
> this happens to give us zero, hence my testing didn't catch this
> earlier.
>
> This patch fixes the issue by using DIV_ROUND_UP and explicit case to
> to avoid the erroneous shifts.
>
> Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reported-by: Huang Ying <ying.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
> ---
>
> Joerg -- please can you apply this as a fix for 3.20?
Applied to my fixes branch, thanks Will.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386
Date: Wed, 25 Feb 2015 13:38:46 +0100 [thread overview]
Message-ID: <20150225123845.GA5362@8bytes.org> (raw)
In-Reply-To: <1424111900-23887-1-git-send-email-will.deacon@arm.com>
On Mon, Feb 16, 2015 at 06:38:20PM +0000, Will Deacon wrote:
> Various build/boot bots have reported WARNs being triggered by the ARM
> iopgtable LPAE self-tests on i386 machines.
>
> This boils down to two instances of right-shifting a 32-bit unsigned
> long (i.e. an iova) by more than the size of the type. On 32-bit ARM,
> this happens to give us zero, hence my testing didn't catch this
> earlier.
>
> This patch fixes the issue by using DIV_ROUND_UP and explicit case to
> to avoid the erroneous shifts.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Reported-by: Huang Ying <ying.huang@intel.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Joerg -- please can you apply this as a fix for 3.20?
Applied to my fixes branch, thanks Will.
next prev parent reply other threads:[~2015-02-25 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 18:38 [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386 Will Deacon
2015-02-16 18:38 ` Will Deacon
[not found] ` <1424111900-23887-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2015-02-25 12:38 ` Joerg Roedel [this message]
2015-02-25 12:38 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225123845.GA5362@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.