From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Sougata Santra <sougata@tuxera.com>,
Christoph Hellwig <hch@lst.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()
Date: Wed, 25 Feb 2015 17:13:03 +0000 [thread overview]
Message-ID: <20150225171303.GF5116@mwanda> (raw)
In-Reply-To: <CABikg9yk7BoL36FMW3sxXOY5MUb-TRDWB_Me3pAjMkpRAU-8ow@mail.gmail.com>
On Wed, Feb 25, 2015 at 03:50:19PM +0100, Sergei Antonov wrote:
> Right you are.
> I would also add 2 things:
> 1. CC the author of the last patch (the one which introduced it).
Huh? Sougata is CC'd. I didn't add a fixes: tag because this is just a
cleanup and has no effect on runtime.
> 2. Unify the way the return code from hfsplus_cat_build_key() is
> checked. Now it has two flavours: "if (unlikely(err < 0))" and "if
> (unlikely(err))". The latter is better.
I'm a bit confused.
1) This function uses "if (unlikely(err)) " consistently.
2) I don't see how any of that relates to this patch??
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Sougata Santra <sougata@tuxera.com>,
Christoph Hellwig <hch@lst.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()
Date: Wed, 25 Feb 2015 20:13:03 +0300 [thread overview]
Message-ID: <20150225171303.GF5116@mwanda> (raw)
In-Reply-To: <CABikg9yk7BoL36FMW3sxXOY5MUb-TRDWB_Me3pAjMkpRAU-8ow@mail.gmail.com>
On Wed, Feb 25, 2015 at 03:50:19PM +0100, Sergei Antonov wrote:
> Right you are.
> I would also add 2 things:
> 1. CC the author of the last patch (the one which introduced it).
Huh? Sougata is CC'd. I didn't add a fixes: tag because this is just a
cleanup and has no effect on runtime.
> 2. Unify the way the return code from hfsplus_cat_build_key() is
> checked. Now it has two flavours: "if (unlikely(err < 0))" and "if
> (unlikely(err))". The latter is better.
I'm a bit confused.
1) This function uses "if (unlikely(err)) " consistently.
2) I don't see how any of that relates to this patch??
regards,
dan carpenter
next prev parent reply other threads:[~2015-02-25 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:36 [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Dan Carpenter
2015-02-25 13:36 ` Dan Carpenter
2015-02-25 14:50 ` Sergei Antonov
2015-02-25 14:50 ` Sergei Antonov
2015-02-25 17:13 ` Dan Carpenter [this message]
2015-02-25 17:13 ` Dan Carpenter
2015-02-25 18:20 ` Sergei Antonov
2015-02-25 18:20 ` Sergei Antonov
2015-02-25 18:30 ` Dan Carpenter
2015-02-25 18:30 ` Dan Carpenter
2015-02-25 18:37 ` Sergei Antonov
2015-02-25 18:37 ` Sergei Antonov
2015-02-25 18:50 ` Dan Carpenter
2015-02-25 18:50 ` Dan Carpenter
2015-02-25 17:42 ` Viacheslav Dubeyko
2015-02-25 17:42 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225171303.GF5116@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=saproj@gmail.com \
--cc=slava@dubeyko.com \
--cc=sougata@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.