From: NeilBrown <neilb@suse.de>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
GTA04 owners <gta04-owner@goldelico.com>
Subject: [PATCH] OMAP: DSS: DPI: disable vt-switch on suspend/resume.
Date: Wed, 25 Feb 2015 09:37:08 +0000 [thread overview]
Message-ID: <20150225203708.0eb2fa96@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
These devices do not need to return to non-graphic console
for suspend, so disable that option.
This means there is less work to do in the suspend/resume cycle,
making it smoother and cheaper.
Signed-off-by: NeilBrown <neil@brown.name>
--
Hi Tomi,
I wonder if you would consider this patch too. It works for me and
removes pointless vt switching. I assume no-one would need or want that
switching on suspend/resume but I guess I cannot be certain.
Maybe a module-parameter could be used if there was any uncertainty.
thanks,
NeilBrown
diff --git a/drivers/video/fbdev/omap2/dss/dpi.c b/drivers/video/fbdev/omap2/dss/dpi.c
index f83e7b030249..4a29bab4ade3 100644
--- a/drivers/video/fbdev/omap2/dss/dpi.c
+++ b/drivers/video/fbdev/omap2/dss/dpi.c
@@ -32,6 +32,7 @@
#include <linux/string.h>
#include <linux/of.h>
#include <linux/clk.h>
+#include <linux/suspend.h>
#include <video/omapdss.h>
@@ -798,6 +799,8 @@ static int omap_dpi_probe(struct platform_device *pdev)
mutex_init(&dpi->lock);
dpi_init_output(pdev);
+ /* No need to vt_switch in suspend/resume */
+ pm_set_vt_switch(0);
return 0;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.de>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
GTA04 owners <gta04-owner@goldelico.com>
Subject: [PATCH] OMAP: DSS: DPI: disable vt-switch on suspend/resume.
Date: Wed, 25 Feb 2015 20:37:08 +1100 [thread overview]
Message-ID: <20150225203708.0eb2fa96@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
These devices do not need to return to non-graphic console
for suspend, so disable that option.
This means there is less work to do in the suspend/resume cycle,
making it smoother and cheaper.
Signed-off-by: NeilBrown <neil@brown.name>
--
Hi Tomi,
I wonder if you would consider this patch too. It works for me and
removes pointless vt switching. I assume no-one would need or want that
switching on suspend/resume but I guess I cannot be certain.
Maybe a module-parameter could be used if there was any uncertainty.
thanks,
NeilBrown
diff --git a/drivers/video/fbdev/omap2/dss/dpi.c b/drivers/video/fbdev/omap2/dss/dpi.c
index f83e7b030249..4a29bab4ade3 100644
--- a/drivers/video/fbdev/omap2/dss/dpi.c
+++ b/drivers/video/fbdev/omap2/dss/dpi.c
@@ -32,6 +32,7 @@
#include <linux/string.h>
#include <linux/of.h>
#include <linux/clk.h>
+#include <linux/suspend.h>
#include <video/omapdss.h>
@@ -798,6 +799,8 @@ static int omap_dpi_probe(struct platform_device *pdev)
mutex_init(&dpi->lock);
dpi_init_output(pdev);
+ /* No need to vt_switch in suspend/resume */
+ pm_set_vt_switch(0);
return 0;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next reply other threads:[~2015-02-25 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 9:37 NeilBrown [this message]
2015-02-25 9:37 ` [PATCH] OMAP: DSS: DPI: disable vt-switch on suspend/resume NeilBrown
2015-02-25 10:03 ` Tomi Valkeinen
2015-02-25 10:03 ` Tomi Valkeinen
2015-02-25 10:03 ` Tomi Valkeinen
2015-02-25 22:26 ` NeilBrown
2015-02-25 22:26 ` NeilBrown
2015-02-25 22:26 ` NeilBrown
2015-03-02 21:03 ` Pavel Machek
2015-03-02 21:03 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225203708.0eb2fa96@notabene.brown \
--to=neilb@suse.de \
--cc=gta04-owner@goldelico.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.