From: Bjorn Helgaas <bhelgaas@google.com>
To: Phong Tran <tranmanphong@gmail.com>
Cc: tinamdar@apm.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] PCI: xgene: Fix the map_bus callback prototype
Date: Wed, 25 Feb 2015 19:23:12 -0600 [thread overview]
Message-ID: <20150226012312.GV6220@google.com> (raw)
In-Reply-To: <20150226011824.GU6220@google.com>
On Wed, Feb 25, 2015 at 07:18:24PM -0600, Bjorn Helgaas wrote:
> [+cc Fabio]
>
> On Mon, Feb 23, 2015 at 05:21:39PM +0700, Phong Tran wrote:
> > The return value should be void __iomem *.
> > Tested by compile only.
> >
> > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
>
> I've already applied an identical patch from Fabio Estevam. I added
> Arnd's ack to it and also mentioned you in the credits, Phong.
Dropped in favor of a more complete fix:
https://patchwork.ozlabs.org/patch/440759/
> > ---
> > drivers/pci/host/pci-xgene.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> > index aab5547..9c3bfd8 100644
> > --- a/drivers/pci/host/pci-xgene.c
> > +++ b/drivers/pci/host/pci-xgene.c
> > @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
> > return false;
> > }
> >
> > -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > int offset)
> > {
> > struct xgene_pcie_port *port = bus->sysdata;
> > --
> > 2.1.0
> >
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: xgene: Fix the map_bus callback prototype
Date: Wed, 25 Feb 2015 19:23:12 -0600 [thread overview]
Message-ID: <20150226012312.GV6220@google.com> (raw)
In-Reply-To: <20150226011824.GU6220@google.com>
On Wed, Feb 25, 2015 at 07:18:24PM -0600, Bjorn Helgaas wrote:
> [+cc Fabio]
>
> On Mon, Feb 23, 2015 at 05:21:39PM +0700, Phong Tran wrote:
> > The return value should be void __iomem *.
> > Tested by compile only.
> >
> > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
>
> I've already applied an identical patch from Fabio Estevam. I added
> Arnd's ack to it and also mentioned you in the credits, Phong.
Dropped in favor of a more complete fix:
https://patchwork.ozlabs.org/patch/440759/
> > ---
> > drivers/pci/host/pci-xgene.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> > index aab5547..9c3bfd8 100644
> > --- a/drivers/pci/host/pci-xgene.c
> > +++ b/drivers/pci/host/pci-xgene.c
> > @@ -127,7 +127,7 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
> > return false;
> > }
> >
> > -static int xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > +static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> > int offset)
> > {
> > struct xgene_pcie_port *port = bus->sysdata;
> > --
> > 2.1.0
> >
next prev parent reply other threads:[~2015-02-26 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 10:21 [PATCH] PCI: xgene: Fix the map_bus callback prototype Phong Tran
2015-02-23 10:21 ` Phong Tran
2015-02-23 11:23 ` Arnd Bergmann
2015-02-23 11:23 ` Arnd Bergmann
2015-02-26 1:18 ` Bjorn Helgaas
2015-02-26 1:18 ` Bjorn Helgaas
2015-02-26 1:23 ` Bjorn Helgaas [this message]
2015-02-26 1:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226012312.GV6220@google.com \
--to=bhelgaas@google.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tinamdar@apm.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.