* [PATCH] Staging: rtl8188eu: Replace if-else block with switch-case
@ 2015-02-26 12:44 Vatika Harlalka
2015-02-26 13:45 ` [Outreachy kernel] " Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Vatika Harlalka @ 2015-02-26 12:44 UTC (permalink / raw)
To: outreachy-kernel
Replace if-else block with switch-case to make it more compact
and increase readability.
Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index 1e963bf..baebe35 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -552,21 +552,29 @@ static void store_pwrindex_offset(struct adapter *Adapter, u32 regaddr, u32 bitm
}
}
-static void rtl_addr_delay(struct adapter *adapt, u32 addr, u32 bit_mask, u32 data)
+static void rtl_addr_delay(struct adapter *adapt,
+ u32 addr, u32 bit_mask, u32 data)
{
- if (addr == 0xfe) {
+ switch (addr) {
+ case 0xfe:
msleep(50);
- } else if (addr == 0xfd) {
+ break;
+ case 0xfd:
mdelay(5);
- } else if (addr == 0xfc) {
+ break;
+ case 0xfc:
mdelay(1);
- } else if (addr == 0xfb) {
+ break;
+ case 0xfb:
udelay(50);
- } else if (addr == 0xfa) {
+ break;
+ case 0xfa:
udelay(5);
- } else if (addr == 0xf9) {
+ break;
+ case 0xf9:
udelay(1);
- } else{
+ break;
+ default:
store_pwrindex_offset(adapt, addr, bit_mask, data);
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Replace if-else block with switch-case
2015-02-26 12:44 [PATCH] Staging: rtl8188eu: Replace if-else block with switch-case Vatika Harlalka
@ 2015-02-26 13:45 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-02-26 13:45 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Vatika Harlalka
On Thursday 26 February 2015 18:14:02 Vatika Harlalka wrote:
> Replace if-else block with switch-case to make it more compact
> and increase readability.
>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 12:44 [PATCH] Staging: rtl8188eu: Replace if-else block with switch-case Vatika Harlalka
2015-02-26 13:45 ` [Outreachy kernel] " Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.