From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Ball <chris@printf.net>, Aisheng Dong <b29396@freescale.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Shawn Guo <shawn.guo@linaro.org>,
Dirk Behme <dirk.behme@de.bosch.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning
Date: Thu, 26 Feb 2015 20:37:55 +0000 [thread overview]
Message-ID: <20150226203755.GD6820@mwanda> (raw)
Static checkers suggest that probably we intended to put curly braces
around the writel() to make it part of the else path. But, I think
actually the indenting is off and the code works fine as is.
The stray tab was introduced in 0322191e6298 ('mmc: sdhci-esdhc-imx: add
sd3.0 SDR clock tuning support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 10ef824..9cce5cf 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -416,7 +416,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
new_val |= ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
else
new_val &= ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
- writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
+ writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
return;
case SDHCI_HOST_CONTROL2:
new_val = readl(host->ioaddr + ESDHC_VENDOR_SPEC);
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Ball <chris@printf.net>, Aisheng Dong <b29396@freescale.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Shawn Guo <shawn.guo@linaro.org>,
Dirk Behme <dirk.behme@de.bosch.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning
Date: Thu, 26 Feb 2015 23:37:55 +0300 [thread overview]
Message-ID: <20150226203755.GD6820@mwanda> (raw)
Static checkers suggest that probably we intended to put curly braces
around the writel() to make it part of the else path. But, I think
actually the indenting is off and the code works fine as is.
The stray tab was introduced in 0322191e6298 ('mmc: sdhci-esdhc-imx: add
sd3.0 SDR clock tuning support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 10ef824..9cce5cf 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -416,7 +416,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
new_val |= ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
else
new_val &= ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
- writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
+ writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
return;
case SDHCI_HOST_CONTROL2:
new_val = readl(host->ioaddr + ESDHC_VENDOR_SPEC);
next reply other threads:[~2015-02-26 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 20:37 Dan Carpenter [this message]
2015-02-26 20:37 ` [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning Dan Carpenter
2015-02-27 7:14 ` Dong Aisheng
2015-02-27 7:14 ` Dong Aisheng
2015-03-05 13:48 ` Ulf Hansson
2015-03-05 13:48 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226203755.GD6820@mwanda \
--to=dan.carpenter@oracle.com \
--cc=b29396@freescale.com \
--cc=chris@printf.net \
--cc=dirk.behme@de.bosch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=shawn.guo@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.