All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: removed trailing whitespace in dgnc
@ 2015-02-21 20:53 Yeliz Taneroglu
  2015-02-21 21:18 ` [Outreachy kernel] " Julia Lawall
  2015-02-26 21:15 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Yeliz Taneroglu @ 2015-02-21 20:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Yeliz Taneroglu

Removed all trailing whitespace in
"drivers/staging/dgnc/dgnc_sysfs.c"

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
 drivers/staging/dgnc/dgnc_sysfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 0d425ad..6c3b387 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -125,9 +125,8 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
 	rc |= driver_create_file(driverfs, &driver_attr_debug);
 	rc |= driver_create_file(driverfs, &driver_attr_rawreadok);
 	rc |= driver_create_file(driverfs, &driver_attr_pollrate);
-	if (rc) {
+	if (rc)
 		printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
-	}
 }
 
 
@@ -397,9 +396,8 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
 	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_txcount);
 	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
 	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
-	if (rc) {
+	if (rc)
 		printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
-	}
 }
 
 
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: removed trailing whitespace in dgnc
  2015-02-21 20:53 [PATCH] Staging: removed trailing whitespace in dgnc Yeliz Taneroglu
@ 2015-02-21 21:18 ` Julia Lawall
  2015-02-26 21:15 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-02-21 21:18 UTC (permalink / raw)
  To: Yeliz Taneroglu; +Cc: outreachy-kernel

On Sat, 21 Feb 2015, Yeliz Taneroglu wrote:

> Removed all trailing whitespace in
> "drivers/staging/dgnc/dgnc_sysfs.c"

You removed braces.  If that is all you did, you should change the 
subject and the commit message.  It you removed the braces and removed 
trailing whitespace, then add about the braces in the commit message.

julia

> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_sysfs.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
> index 0d425ad..6c3b387 100644
> --- a/drivers/staging/dgnc/dgnc_sysfs.c
> +++ b/drivers/staging/dgnc/dgnc_sysfs.c
> @@ -125,9 +125,8 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
>  	rc |= driver_create_file(driverfs, &driver_attr_debug);
>  	rc |= driver_create_file(driverfs, &driver_attr_rawreadok);
>  	rc |= driver_create_file(driverfs, &driver_attr_pollrate);
> -	if (rc) {
> +	if (rc)
>  		printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
> -	}
>  }
>  
>  
> @@ -397,9 +396,8 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
>  	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_ports_txcount);
>  	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
>  	rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
> -	if (rc) {
> +	if (rc)
>  		printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
> -	}
>  }
>  
>  
> -- 
> 1.8.3.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424551997-5909-1-git-send-email-yeliztaneroglu%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: removed trailing whitespace in dgnc
  2015-02-21 20:53 [PATCH] Staging: removed trailing whitespace in dgnc Yeliz Taneroglu
  2015-02-21 21:18 ` [Outreachy kernel] " Julia Lawall
@ 2015-02-26 21:15 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-02-26 21:15 UTC (permalink / raw)
  To: Yeliz Taneroglu; +Cc: outreachy-kernel

On Sat, Feb 21, 2015 at 10:53:17PM +0200, Yeliz Taneroglu wrote:
> Removed all trailing whitespace in
> "drivers/staging/dgnc/dgnc_sysfs.c"
> 
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_sysfs.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

This patch fails to apply :(


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-26 21:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21 20:53 [PATCH] Staging: removed trailing whitespace in dgnc Yeliz Taneroglu
2015-02-21 21:18 ` [Outreachy kernel] " Julia Lawall
2015-02-26 21:15 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.