* [PATCH] Staging: rtl8192u: Fix do not use // c99 comments.
@ 2015-02-21 13:10 Dilek Uzulmez
2015-02-26 21:26 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dilek Uzulmez @ 2015-02-21 13:10 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
This patch fixes "do not use // C99 comments" errors in ieee80211_crypt.c
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 5533221..7435126 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -11,7 +11,7 @@
*
*/
-//#include <linux/config.h>
+/*#include <linux/config.h> */
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Fix do not use // c99 comments.
2015-02-21 13:10 [PATCH] Staging: rtl8192u: Fix do not use // c99 comments Dilek Uzulmez
@ 2015-02-26 21:26 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-02-26 21:26 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Sat, Feb 21, 2015 at 03:10:47PM +0200, Dilek Uzulmez wrote:
> This patch fixes "do not use // C99 comments" errors in ieee80211_crypt.c
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..7435126 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -11,7 +11,7 @@
> *
> */
>
> -//#include <linux/config.h>
> +/*#include <linux/config.h> */
Please just delete this line, no need to keep it commented out.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Staging: rtl8192u: Fix do not use // c99 comments.
@ 2015-02-22 12:50 Dilek Uzulmez
2015-02-22 12:52 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Dilek Uzulmez @ 2015-02-22 12:50 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
This patch fixes "do not use // C99 comments" errors in ieee80211_module.c
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index afbd09d..d8900dd 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -31,7 +31,7 @@
*******************************************************************************/
#include <linux/compiler.h>
-//#include <linux/config.h>
+/* #include <linux/config.h> */
#include <linux/errno.h>
#include <linux/if_arp.h>
#include <linux/in6.h>
@@ -141,7 +141,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
spin_lock_init(&ieee->wpax_suitlist_lock);
spin_lock_init(&ieee->bw_spinlock);
spin_lock_init(&ieee->reorder_spinlock);
- //added by WB
+ /* added by WB */
atomic_set(&(ieee->atm_chnlop), 0);
atomic_set(&(ieee->atm_swbw), 0);
@@ -153,7 +153,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
ieee->ieee802_1x = 1;
ieee->raw_tx = 0;
//ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead.
- ieee->hwsec_active = 0; //disable hwsec, switch it on when necessary.
+ ieee->hwsec_active = 0; /* disable hwsec, switch it on when necessary. */
ieee80211_softmac_init(ieee);
@@ -164,7 +164,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
goto failed;
}
HTUpdateDefaultSetting(ieee);
- HTInitializeHTInfo(ieee); //may move to other place.
+ HTInitializeHTInfo(ieee); /* may move to other place. */
TSInitialize(ieee);
for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)
@@ -176,7 +176,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
ieee->last_packet_time[i] = 0;
}
-//These function were added to load crypte module autoly
+/* These function were added to load crypte module autoly */
ieee80211_tkip_null();
ieee80211_wep_null();
ieee80211_ccmp_null();
@@ -195,7 +195,7 @@ void free_ieee80211(struct net_device *dev)
{
struct ieee80211_device *ieee = netdev_priv(dev);
int i;
- //struct list_head *p, *q;
+ /* struct list_head *p, *q; */
// del_timer_sync(&ieee->SwBwTimer);
kfree(ieee->pHTInfo);
ieee->pHTInfo = NULL;
@@ -239,7 +239,7 @@ static int debug = \
// IEEE80211_DL_REORDER|
// IEEE80211_DL_TRACE |
//IEEE80211_DL_DATA |
- IEEE80211_DL_ERR //awayls open this flags to show error out
+ IEEE80211_DL_ERR /* awayls open this flags to show error out */
;
static struct proc_dir_entry *ieee80211_proc;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Fix do not use // c99 comments.
2015-02-22 12:50 Dilek Uzulmez
@ 2015-02-22 12:52 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2015-02-22 12:52 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Sun, 22 Feb 2015, Dilek Uzulmez wrote:
> This patch fixes "do not use // C99 comments" errors in ieee80211_module.c
I believe that someone else has already made these changes.
julia
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index afbd09d..d8900dd 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -31,7 +31,7 @@
> *******************************************************************************/
>
> #include <linux/compiler.h>
> -//#include <linux/config.h>
> +/* #include <linux/config.h> */
> #include <linux/errno.h>
> #include <linux/if_arp.h>
> #include <linux/in6.h>
> @@ -141,7 +141,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> spin_lock_init(&ieee->wpax_suitlist_lock);
> spin_lock_init(&ieee->bw_spinlock);
> spin_lock_init(&ieee->reorder_spinlock);
> - //added by WB
> + /* added by WB */
> atomic_set(&(ieee->atm_chnlop), 0);
> atomic_set(&(ieee->atm_swbw), 0);
>
> @@ -153,7 +153,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> ieee->ieee802_1x = 1;
> ieee->raw_tx = 0;
> //ieee->hwsec_support = 1; //defalt support hw security. //use module_param instead.
> - ieee->hwsec_active = 0; //disable hwsec, switch it on when necessary.
> + ieee->hwsec_active = 0; /* disable hwsec, switch it on when necessary. */
>
> ieee80211_softmac_init(ieee);
>
> @@ -164,7 +164,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> goto failed;
> }
> HTUpdateDefaultSetting(ieee);
> - HTInitializeHTInfo(ieee); //may move to other place.
> + HTInitializeHTInfo(ieee); /* may move to other place. */
> TSInitialize(ieee);
>
> for (i = 0; i < IEEE_IBSS_MAC_HASH_SIZE; i++)
> @@ -176,7 +176,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> ieee->last_packet_time[i] = 0;
> }
>
> -//These function were added to load crypte module autoly
> +/* These function were added to load crypte module autoly */
> ieee80211_tkip_null();
> ieee80211_wep_null();
> ieee80211_ccmp_null();
> @@ -195,7 +195,7 @@ void free_ieee80211(struct net_device *dev)
> {
> struct ieee80211_device *ieee = netdev_priv(dev);
> int i;
> - //struct list_head *p, *q;
> + /* struct list_head *p, *q; */
> // del_timer_sync(&ieee->SwBwTimer);
> kfree(ieee->pHTInfo);
> ieee->pHTInfo = NULL;
> @@ -239,7 +239,7 @@ static int debug = \
> // IEEE80211_DL_REORDER|
> // IEEE80211_DL_TRACE |
> //IEEE80211_DL_DATA |
> - IEEE80211_DL_ERR //awayls open this flags to show error out
> + IEEE80211_DL_ERR /* awayls open this flags to show error out */
> ;
> static struct proc_dir_entry *ieee80211_proc;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424609406-6259-1-git-send-email-dilekuzulmez%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 21:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-21 13:10 [PATCH] Staging: rtl8192u: Fix do not use // c99 comments Dilek Uzulmez
2015-02-26 21:26 ` [Outreachy kernel] " Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-02-22 12:50 Dilek Uzulmez
2015-02-22 12:52 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.