[PATCH v4] Convert simple_strtoul to kstrtoul

[PATCH v4] Convert simple_strtoul to kstrtoul

[Navya Sri Nizamkari]

This patch fixes the checkpatch.pl warning:
simple_strtoul is obsolete, use kstrtoul instead.

Replaced simple_strtoul with kstrtoul as both can perform parsing error
checks on the string to the converted. The parsing error condition for
simple_strtoul is that the string to be converted is same as the converted
string, with kstrtoul the return value is non-zero in case of this error.

Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
Changes in v4:
    -Updated commit explanation to be more generic.

 drivers/staging/media/parport/bw-qcam.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/parport/bw-qcam.c b/drivers/staging/media/parport/bw-qcam.c
index 67b9da1..6c9b400 100644
--- a/drivers/staging/media/parport/bw-qcam.c
+++ b/drivers/staging/media/parport/bw-qcam.c
@@ -1106,10 +1106,8 @@ static int accept_bwqcam(struct parport *port)
 	if (parport[0] && strncmp(parport[0], "auto", 4) != 0) {
 		/* user gave parport parameters */
 		for (n = 0; n < MAX_CAMS && parport[n]; n++) {
-			char *ep;
 			unsigned long r;
-			r = simple_strtoul(parport[n], &ep, 0);
-			if (ep == parport[n]) {
+			if (kstrtoul(parport[n], 0, &r)) {
 				printk(KERN_ERR
 					"bw-qcam: bad port specifier \"%s\"\n",
 					parport[n]);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v4] Convert simple_strtoul to kstrtoul

[Greg KH]

On Fri, Feb 20, 2015 at 07:46:16PM +0530, Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl warning:
> simple_strtoul is obsolete, use kstrtoul instead.
> 
> Replaced simple_strtoul with kstrtoul as both can perform parsing error
> checks on the string to the converted. The parsing error condition for
> simple_strtoul is that the string to be converted is same as the converted
> string, with kstrtoul the return value is non-zero in case of this error.
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v4:
>     -Updated commit explanation to be more generic.
> 
>  drivers/staging/media/parport/bw-qcam.c | 4 +---

This file is no longer in Linus's tree :(