Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Feb 26, 2015 at 10:55:13PM +0100, Ksenija Stanojević wrote:
> On Thu, Feb 26, 2015 at 10:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Feb 23, 2015 at 08:56:19PM +0100, Ksenija Stanojevic wrote:
> >> For dynamic debugging pr_debug() macro is preferred over printk(), which
> >> is the raw way to print something. Issue found by checkpatch.pl.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >> v2: include only changes made to this file.
> >>
> >>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> index 8c1bf1f..7fab680 100644
> >> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
> >>
> >>       priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> >>       if (IS_ERR(priv->tx_tfm)) {
> >> -             printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> >> +             pr_debug("ieee80211_crypt_wep: could not allocate "
> >>                      "crypto API arc4\n");
> >>               priv->tx_tfm = NULL;
> >>               goto fail;
> >>       }
> >>       priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> >>       if (IS_ERR(priv->rx_tfm)) {
> >> -             printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> >> +             pr_debug("ieee80211_crypt_wep: could not allocate "
> >>                      "crypto API arc4\n");
> >
> > Please use net_dbg() instead
> >
> I already tried netdev_dbg, but there's no pointer to net stucture in
> function argument list.

Ok, then please resend the patch, and add that information to the
changelog section, so that I and everyone else knows this.

thanks,

greg k-h