* [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()
@ 2015-02-23 19:56 Ksenija Stanojevic
2015-02-23 19:57 ` [Outreachy kernel] " Jes Sorensen
2015-02-26 21:45 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Ksenija Stanojevic @ 2015-02-23 19:56 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
For dynamic debugging pr_debug() macro is preferred over printk(), which
is the raw way to print something. Issue found by checkpatch.pl.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
v2: include only changes made to this file.
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
index 8c1bf1f..7fab680 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
@@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->tx_tfm)) {
- printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
+ pr_debug("ieee80211_crypt_wep: could not allocate "
"crypto API arc4\n");
priv->tx_tfm = NULL;
goto fail;
}
priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->rx_tfm)) {
- printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
+ pr_debug("ieee80211_crypt_wep: could not allocate "
"crypto API arc4\n");
priv->rx_tfm = NULL;
goto fail;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()
2015-02-23 19:56 [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug() Ksenija Stanojevic
@ 2015-02-23 19:57 ` Jes Sorensen
2015-02-26 21:45 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Jes Sorensen @ 2015-02-23 19:57 UTC (permalink / raw)
To: Ksenija Stanojevic, outreachy-kernel
On 02/23/15 14:56, Ksenija Stanojevic wrote:
> For dynamic debugging pr_debug() macro is preferred over printk(), which
> is the raw way to print something. Issue found by checkpatch.pl.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v2: include only changes made to this file.
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good!
Jes
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> index 8c1bf1f..7fab680 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
>
> priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> if (IS_ERR(priv->tx_tfm)) {
> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> + pr_debug("ieee80211_crypt_wep: could not allocate "
> "crypto API arc4\n");
> priv->tx_tfm = NULL;
> goto fail;
> }
> priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> if (IS_ERR(priv->rx_tfm)) {
> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> + pr_debug("ieee80211_crypt_wep: could not allocate "
> "crypto API arc4\n");
> priv->rx_tfm = NULL;
> goto fail;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()
2015-02-23 19:56 [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug() Ksenija Stanojevic
2015-02-23 19:57 ` [Outreachy kernel] " Jes Sorensen
@ 2015-02-26 21:45 ` Greg KH
2015-02-26 21:55 ` Ksenija Stanojević
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2015-02-26 21:45 UTC (permalink / raw)
To: Ksenija Stanojevic; +Cc: outreachy-kernel
On Mon, Feb 23, 2015 at 08:56:19PM +0100, Ksenija Stanojevic wrote:
> For dynamic debugging pr_debug() macro is preferred over printk(), which
> is the raw way to print something. Issue found by checkpatch.pl.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v2: include only changes made to this file.
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> index 8c1bf1f..7fab680 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
>
> priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> if (IS_ERR(priv->tx_tfm)) {
> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> + pr_debug("ieee80211_crypt_wep: could not allocate "
> "crypto API arc4\n");
> priv->tx_tfm = NULL;
> goto fail;
> }
> priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> if (IS_ERR(priv->rx_tfm)) {
> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> + pr_debug("ieee80211_crypt_wep: could not allocate "
> "crypto API arc4\n");
Please use net_dbg() instead
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()
2015-02-26 21:45 ` Greg KH
@ 2015-02-26 21:55 ` Ksenija Stanojević
2015-02-26 22:26 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Ksenija Stanojević @ 2015-02-26 21:55 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Thu, Feb 26, 2015 at 10:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Feb 23, 2015 at 08:56:19PM +0100, Ksenija Stanojevic wrote:
>> For dynamic debugging pr_debug() macro is preferred over printk(), which
>> is the raw way to print something. Issue found by checkpatch.pl.
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>> v2: include only changes made to this file.
>>
>> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>> index 8c1bf1f..7fab680 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
>>
>> priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
>> if (IS_ERR(priv->tx_tfm)) {
>> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
>> + pr_debug("ieee80211_crypt_wep: could not allocate "
>> "crypto API arc4\n");
>> priv->tx_tfm = NULL;
>> goto fail;
>> }
>> priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
>> if (IS_ERR(priv->rx_tfm)) {
>> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
>> + pr_debug("ieee80211_crypt_wep: could not allocate "
>> "crypto API arc4\n");
>
> Please use net_dbg() instead
>
I already tried netdev_dbg, but there's no pointer to net stucture in
function argument list.
Ksenija
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug()
2015-02-26 21:55 ` Ksenija Stanojević
@ 2015-02-26 22:26 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2015-02-26 22:26 UTC (permalink / raw)
To: Ksenija Stanojević; +Cc: outreachy-kernel
On Thu, Feb 26, 2015 at 10:55:13PM +0100, Ksenija Stanojević wrote:
> On Thu, Feb 26, 2015 at 10:45 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Feb 23, 2015 at 08:56:19PM +0100, Ksenija Stanojevic wrote:
> >> For dynamic debugging pr_debug() macro is preferred over printk(), which
> >> is the raw way to print something. Issue found by checkpatch.pl.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >> v2: include only changes made to this file.
> >>
> >> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> index 8c1bf1f..7fab680 100644
> >> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> >> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
> >>
> >> priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> >> if (IS_ERR(priv->tx_tfm)) {
> >> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> >> + pr_debug("ieee80211_crypt_wep: could not allocate "
> >> "crypto API arc4\n");
> >> priv->tx_tfm = NULL;
> >> goto fail;
> >> }
> >> priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
> >> if (IS_ERR(priv->rx_tfm)) {
> >> - printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
> >> + pr_debug("ieee80211_crypt_wep: could not allocate "
> >> "crypto API arc4\n");
> >
> > Please use net_dbg() instead
> >
> I already tried netdev_dbg, but there's no pointer to net stucture in
> function argument list.
Ok, then please resend the patch, and add that information to the
changelog section, so that I and everyone else knows this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-26 22:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 19:56 [PATCH v2] Staging: rtl8192u: Replace printk() with pr_debug() Ksenija Stanojevic
2015-02-23 19:57 ` [Outreachy kernel] " Jes Sorensen
2015-02-26 21:45 ` Greg KH
2015-02-26 21:55 ` Ksenija Stanojević
2015-02-26 22:26 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.