* [PATCH v3] Staging: rtl8192u: Replace printk() with pr_debug()
@ 2015-02-26 22:49 Ksenija Stanojevic
2015-02-26 23:27 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ksenija Stanojevic @ 2015-02-26 22:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
For dynamic debugging netdev_dbg(), dev_dbg() or pr_debug() macro is
preferred over printk(), which is the raw way to print something.
Network system has it's own printk format, netdev_dbg, but in this case
function's argument list has no pointer to a struct netdevice so
pr_debug is used instead.
Issue found by checkpatch.pl.
---
v3: Change commit message.
v2: Include only changes made to this file.
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
index 8c1bf1f..7fab680 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
@@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->tx_tfm)) {
- printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
+ pr_debug("ieee80211_crypt_wep: could not allocate "
"crypto API arc4\n");
priv->tx_tfm = NULL;
goto fail;
}
priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->rx_tfm)) {
- printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
+ pr_debug("ieee80211_crypt_wep: could not allocate "
"crypto API arc4\n");
priv->rx_tfm = NULL;
goto fail;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] Staging: rtl8192u: Replace printk() with pr_debug()
2015-02-26 22:49 [PATCH v3] Staging: rtl8192u: Replace printk() with pr_debug() Ksenija Stanojevic
@ 2015-02-26 23:27 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-02-26 23:27 UTC (permalink / raw)
To: Ksenija Stanojevic; +Cc: outreachy-kernel
On Thu, Feb 26, 2015 at 11:49:10PM +0100, Ksenija Stanojevic wrote:
> For dynamic debugging netdev_dbg(), dev_dbg() or pr_debug() macro is
> preferred over printk(), which is the raw way to print something.
> Network system has it's own printk format, netdev_dbg, but in this case
> function's argument list has no pointer to a struct netdevice so
> pr_debug is used instead.
> Issue found by checkpatch.pl.
> ---
> v3: Change commit message.
> v2: Include only changes made to this file.
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
No signed-off-by: Line :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 22:49 [PATCH v3] Staging: rtl8192u: Replace printk() with pr_debug() Ksenija Stanojevic
2015-02-26 23:27 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.