[PATCH] Staging: rtl8188eu: Move variable assignment

[PATCH] Staging: rtl8188eu: Move variable assignment

[Vatika Harlalka]

Variable path_on is assigned explicitly in the if branch and so
its assignment outside can be moved to the else branch.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/rtl8188eu/hal/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
index 56c0bc9..006b723 100644
--- a/drivers/staging/rtl8188eu/hal/phy.c
+++ b/drivers/staging/rtl8188eu/hal/phy.c
@@ -980,11 +980,11 @@ static void path_adda_on(struct adapter *adapt, u32 *adda_reg,
 	u32 path_on;
 	u32 i;
 
-	path_on = is_path_a_on ? 0x04db25a4 : 0x0b1b25a4;
 	if (!is2t) {
 		path_on = 0x0bdb25a0;
 		phy_set_bb_reg(adapt, adda_reg[0], bMaskDWord, 0x0b1b25a0);
 	} else {
+		path_on = is_path_a_on ? 0x04db25a4 : 0x0b1b25a4;
 		phy_set_bb_reg(adapt, adda_reg[0], bMaskDWord, path_on);
 	}
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Move variable assignment

[Julia Lawall]

On Fri, 27 Feb 2015, Vatika Harlalka wrote:

> Variable path_on is assigned explicitly in the if branch and so
> its assignment outside can be moved to the else branch.

Clever :)

julia

>
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c
> index 56c0bc9..006b723 100644
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -980,11 +980,11 @@ static void path_adda_on(struct adapter *adapt, u32 *adda_reg,
>  	u32 path_on;
>  	u32 i;
>
> -	path_on = is_path_a_on ? 0x04db25a4 : 0x0b1b25a4;
>  	if (!is2t) {
>  		path_on = 0x0bdb25a0;
>  		phy_set_bb_reg(adapt, adda_reg[0], bMaskDWord, 0x0b1b25a0);
>  	} else {
> +		path_on = is_path_a_on ? 0x04db25a4 : 0x0b1b25a4;
>  		phy_set_bb_reg(adapt, adda_reg[0], bMaskDWord, path_on);
>  	}
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150227094802.GA12516%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>