All of lore.kernel.org
 help / color / mirror / Atom feed
* [peterz-queue:perf/core 6/22] kernel/module.c:163:29: sparse: symbol 'mod_tree_ops' was not declared. Should it be static?
@ 2015-02-27 18:50 kbuild test robot
  2015-02-27 18:50 ` [PATCH peterz-queue] module: mod_tree_ops can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-02-27 18:50 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: kbuild-all, Rusty Russell, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core
head:   2dcf36d89d58c88c81f37ec87045080d5bd8d226
commit: addc15e4e5078ee46a6b7179b44f5b37761f2cc2 [6/22] module: Optimize __module_address() using a latched RB-tree
reproduce:
  # apt-get install sparse
  git checkout addc15e4e5078ee46a6b7179b44f5b37761f2cc2
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> kernel/module.c:163:29: sparse: symbol 'mod_tree_ops' was not declared. Should it be static?
   kernel/module.c:304:6: sparse: symbol '__module_put_and_exit' redeclared with different type (originally declared at include/linux/module.h:453) - different modifiers

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH peterz-queue] module: mod_tree_ops can be static
  2015-02-27 18:50 [peterz-queue:perf/core 6/22] kernel/module.c:163:29: sparse: symbol 'mod_tree_ops' was not declared. Should it be static? kbuild test robot
@ 2015-02-27 18:50 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-02-27 18:50 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: kbuild-all, Rusty Russell, linux-kernel

kernel/module.c:163:29: sparse: symbol 'mod_tree_ops' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 module.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 7b12181..10fe9d1 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -160,7 +160,7 @@ mod_tree_comp(unsigned long val, struct latch_tree_node *n)
 	return 0;
 }
 
-const struct latch_tree_ops mod_tree_ops = {
+static const struct latch_tree_ops mod_tree_ops = {
 	.less = mod_tree_less,
 	.comp = mod_tree_comp,
 };

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-27 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 18:50 [peterz-queue:perf/core 6/22] kernel/module.c:163:29: sparse: symbol 'mod_tree_ops' was not declared. Should it be static? kbuild test robot
2015-02-27 18:50 ` [PATCH peterz-queue] module: mod_tree_ops can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.