Re: [Outreachy kernel] [PATCH 14/24] staging: lustre: lov: remove unused variable

[Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>]

On Fri, Feb 27, 2015 at 04:56:19PM +0100, Julia Lawall wrote:
> 
> 
> On Fri, 27 Feb 2015, Aya Mahfouz wrote:
> 
> > This patch removes a variable that was simply used to
> > store the return value of a function call before
> > returning it.
> >
> > The issue was detected and resolved using the following
> > coccinelle script:
> >
> > @@
> > identifier len,f;
> > @@
> >
> > -int len;
> >  ... when != len
> >      when strict
> > -len =
> > +return
> >         f(...);
> > -return len;																																		Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> > ---
> >  drivers/staging/lustre/lustre/lov/lov_obd.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c
> > index 2c6c558..9960b45 100644
> > --- a/drivers/staging/lustre/lustre/lov/lov_obd.c
> > +++ b/drivers/staging/lustre/lustre/lov/lov_obd.c
> > @@ -314,7 +314,7 @@ static int lov_disconnect(struct obd_export *exp)
> >  {
> >  	struct obd_device *obd = class_exp2obd(exp);
> >  	struct lov_obd *lov = &obd->u.lov;
> > -	int i, rc;
> > +	int i;
> >
> >  	if (!lov->lov_tgts)
> >  		goto out;
> > @@ -340,8 +340,7 @@ static int lov_disconnect(struct obd_export *exp)
> >  	obd_putref(obd);
> >
> >  out:
> > -	rc = class_disconnect(exp); /* bz 9811 */
> > -	return rc;
> > +	return class_disconnect(exp);
> 
> The comment should probably be preserved.
> 
> julia
> 
Yes, you're totally right. I've managed it in another patch. Seems that
I wasn't diligent enough.
> >  }
> >
> >  /* Error codes:
> > --
> > 1.9.3
> >
> >
> > --
> > Kind Regards,
> > Aya Saif El-yazal Mahfouz
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/8f04ef8c0696cbc93f0ec76b4860354d50fd0b88.1425035010.git.mahfouz.saif.elyazal%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

-- 
Kind Regards,
Aya Saif El-yazal Mahfouz