Re: [Outreachy kernel] [PATCH 15/24] staging: lustre: lmv: remove unused variables

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Feb 27, 2015 at 03:03:30PM +0200, Aya Mahfouz wrote:
> This patch removes variables that were simply used to
> store the return value of a function call before
> returning it.
> 
> The issue was detected and resolved using the following
> coccinelle script:
> 
> @@
> identifier len,f;
> @@
> 
> -int len;
>  ... when != len
>      when strict
> -len =
> +return
>         f(...);
> -return len;
> 
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 6e446ac..d0dcbf9 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -2555,10 +2555,8 @@ static int lmv_set_lock_data(struct obd_export *exp, __u64 *lockh, void *data,
>  			     __u64 *bits)
>  {
>  	struct lmv_obd	  *lmv = &exp->exp_obd->u.lmv;
> -	int		      rc;
>  
> -	rc =  md_set_lock_data(lmv->tgts[0]->ltd_exp, lockh, data, bits);
> -	return rc;
> +	return  md_set_lock_data(lmv->tgts[0]->ltd_exp, lockh, data, bits);

Extra space here :(