[PATCH] Staging: rtl8188eu: Change return type of function to void

[PATCH] Staging: rtl8188eu: Change return type of function to void

[Vatika Harlalka]

Return is made void as the function is only called once where its
return value is not used.

Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
index baebe35..0fad714 100644
--- a/drivers/staging/rtl8188eu/hal/bb_cfg.c
+++ b/drivers/staging/rtl8188eu/hal/bb_cfg.c
@@ -398,7 +398,7 @@ static void rtl_bb_delay(struct adapter *adapt, u32 addr, u32 data)
 	}
 }
 
-static bool set_baseband_phy_config(struct adapter *adapt)
+static void set_baseband_phy_config(struct adapter *adapt)
 {
 	u32 i;
 	u32 arraylen = sizeof(array_phy_reg_1t_8188e)/sizeof(u32);
@@ -411,7 +411,6 @@ static bool set_baseband_phy_config(struct adapter *adapt)
 		if (v1 < 0xCDCDCDCD)
 			rtl_bb_delay(adapt, v1, v2);
 	}
-	return true;
 }
 
 /*  PHY_REG_PG.TXT  */
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Change return type of function to void

[Greg KH]

On Sat, Feb 28, 2015 at 01:53:45AM +0530, Vatika Harlalka wrote:
> Return is made void as the function is only called once where its
> return value is not used.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

All of your patches for this driver seem to be dependant on the previous
patch, and I don't know what order to apply them in.

So please resend all of them, in an ordered list of patches, so I have a
chance to get them correct.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Change return type of function to void

[Vatika Harlalka]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

I have sent a combined patchset for the patches from this
driver which were not applied.
I'm sorry for the confusion caused!

[-- Attachment #2: Type: text/html, Size: 172 bytes --]