From: Lina Iyer <lina.iyer@linaro.org>
To: Kumar Gala <galak@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@codeaurora.org>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
khilman@linaro.org
Subject: Re: [PATCH v2] qcom: scm: Add qcom_scm_set_warm_boot_addr function
Date: Fri, 27 Feb 2015 15:11:56 -0700 [thread overview]
Message-ID: <20150227221156.GG1678@linaro.org> (raw)
In-Reply-To: <7AD3AAF7-E7D2-4D26-9897-46A6122E66BA@codeaurora.org>
On Fri, Feb 27 2015 at 15:07 -0700, Kumar Gala wrote:
>>>>> +int qcom_scm_set_warm_boot_addr(void *entry, int cpu)
>>>>
>>>> I’d really like to see if we could make the set_boot_addr and set_warm_boot_addr have the same interfaces.
>>>
>>> I am working on making the interfaces similar. There is some check in
>>> the platsmp.c that uses the cold boot flag array to determine the
>>> present cpus. Do you think, we can ignore that check over there? If that
>>> can be done, I will change the interface for cold boot too.
>>
>> I don’t see any reason we can’t add qcom_scm_set_cold_boot_addr() move the flags such that they only exist in qcom_scm_set_boot_addr and make qcom_scm_set_boot_addr static.
>>
>> - k
>
>Looking at this for another minute, I think we should have the interfaces be something like:
>
>qcom_scm_set_cold_boot_addr(void * entry, cpumask_t mask);
>qcom_scm_set_warm_boot_addr(void * entry, cpumask_t mask);
Very similar to what I was thinking. I will send another patchest when I
get to it.
>
>- k
>
>--
>Qualcomm Innovation Center, Inc.
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>a Linux Foundation Collaborative Project
>
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] qcom: scm: Add qcom_scm_set_warm_boot_addr function
Date: Fri, 27 Feb 2015 15:11:56 -0700 [thread overview]
Message-ID: <20150227221156.GG1678@linaro.org> (raw)
In-Reply-To: <7AD3AAF7-E7D2-4D26-9897-46A6122E66BA@codeaurora.org>
On Fri, Feb 27 2015 at 15:07 -0700, Kumar Gala wrote:
>>>>> +int qcom_scm_set_warm_boot_addr(void *entry, int cpu)
>>>>
>>>> I?d really like to see if we could make the set_boot_addr and set_warm_boot_addr have the same interfaces.
>>>
>>> I am working on making the interfaces similar. There is some check in
>>> the platsmp.c that uses the cold boot flag array to determine the
>>> present cpus. Do you think, we can ignore that check over there? If that
>>> can be done, I will change the interface for cold boot too.
>>
>> I don?t see any reason we can?t add qcom_scm_set_cold_boot_addr() move the flags such that they only exist in qcom_scm_set_boot_addr and make qcom_scm_set_boot_addr static.
>>
>> - k
>
>Looking at this for another minute, I think we should have the interfaces be something like:
>
>qcom_scm_set_cold_boot_addr(void * entry, cpumask_t mask);
>qcom_scm_set_warm_boot_addr(void * entry, cpumask_t mask);
Very similar to what I was thinking. I will send another patchest when I
get to it.
>
>- k
>
>--
>Qualcomm Innovation Center, Inc.
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2015-02-27 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 20:47 [PATCH v2] qcom: scm: Add qcom_scm_set_warm_boot_addr function Lina Iyer
2015-02-27 20:47 ` Lina Iyer
2015-02-27 21:33 ` Kumar Gala
2015-02-27 21:33 ` Kumar Gala
2015-02-27 21:51 ` Lina Iyer
2015-02-27 21:51 ` Lina Iyer
2015-02-27 22:01 ` Kumar Gala
2015-02-27 22:01 ` Kumar Gala
2015-02-27 22:07 ` Kumar Gala
2015-02-27 22:07 ` Kumar Gala
2015-02-27 22:11 ` Lina Iyer [this message]
2015-02-27 22:11 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227221156.GG1678@linaro.org \
--to=lina.iyer@linaro.org \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.