* [PATCH] staging: rtl8192e: Remove if conditions.
@ 2015-02-28 21:55 Navya Sri Nizamkari
2015-03-01 22:41 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Navya Sri Nizamkari @ 2015-02-28 21:55 UTC (permalink / raw)
To: outreachy-kernel
This patch removes if conditions with no exececutable
statements in the bodies of those ifs and also no
variable assignments in the if conditional checks.
Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index df0323f..c233a1c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -572,10 +572,6 @@ static int r8192_wx_set_essid(struct net_device *dev,
struct r8192_priv *priv = rtllib_priv(dev);
int ret;
- if ((rtllib_act_scanning(priv->rtllib, false)) &&
- !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
- ; /* TODO - get rid of if */
- }
if (priv->bHwRadioOff == true) {
printk(KERN_INFO "=========>%s():hw radio off,or Rf state is "
"eRfOff, return\n", __func__);
@@ -708,11 +704,6 @@ static int r8192_wx_set_wap(struct net_device *dev,
int ret;
struct r8192_priv *priv = rtllib_priv(dev);
- if ((rtllib_act_scanning(priv->rtllib, false)) &&
- !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
- ; /* TODO - get rid of if */
- }
-
if (priv->bHwRadioOff == true)
return 0;
@@ -763,9 +754,6 @@ static int r8192_wx_set_enc(struct net_device *dev,
{0x00, 0x00, 0x00, 0x00, 0x00, 0x03} };
int i;
- if ((rtllib_act_scanning(priv->rtllib, false)) &&
- !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN))
- ; /* TODO - get rid of if */
if (priv->bHwRadioOff == true)
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Remove if conditions.
2015-02-28 21:55 [PATCH] staging: rtl8192e: Remove if conditions Navya Sri Nizamkari
@ 2015-03-01 22:41 ` Julia Lawall
2015-03-04 8:30 ` Navya Sri Nizamkari
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2015-03-01 22:41 UTC (permalink / raw)
To: Navya Sri Nizamkari; +Cc: outreachy-kernel
On Sun, 1 Mar 2015, Navya Sri Nizamkari wrote:
> This patch removes if conditions with no exececutable
> statements in the bodies of those ifs and also no
> variable assignments in the if conditional checks.
>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index df0323f..c233a1c 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -572,10 +572,6 @@ static int r8192_wx_set_essid(struct net_device *dev,
> struct r8192_priv *priv = rtllib_priv(dev);
> int ret;
>
> - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
> - ; /* TODO - get rid of if */
> - }
I'm not sure that this is correct. Can the call to rtllib_act_scanning
have any side effects? If not, you should mention that explicitly in teh
commit message.
julia
> if (priv->bHwRadioOff == true) {
> printk(KERN_INFO "=========>%s():hw radio off,or Rf state is "
> "eRfOff, return\n", __func__);
> @@ -708,11 +704,6 @@ static int r8192_wx_set_wap(struct net_device *dev,
> int ret;
> struct r8192_priv *priv = rtllib_priv(dev);
>
> - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
> - ; /* TODO - get rid of if */
> - }
> -
> if (priv->bHwRadioOff == true)
> return 0;
>
> @@ -763,9 +754,6 @@ static int r8192_wx_set_enc(struct net_device *dev,
> {0x00, 0x00, 0x00, 0x00, 0x00, 0x03} };
> int i;
>
> - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN))
> - ; /* TODO - get rid of if */
> if (priv->bHwRadioOff == true)
> return 0;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150228215501.GA5201%40localhost.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Remove if conditions.
2015-03-01 22:41 ` [Outreachy kernel] " Julia Lawall
@ 2015-03-04 8:30 ` Navya Sri Nizamkari
2015-03-04 22:32 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Navya Sri Nizamkari @ 2015-03-04 8:30 UTC (permalink / raw)
To: outreachy-kernel; +Cc: navyasri.tech
[-- Attachment #1.1: Type: text/plain, Size: 3998 bytes --]
On Monday, March 2, 2015 at 4:11:11 AM UTC+5:30, Julia Lawall wrote:
>
>
>
> On Sun, 1 Mar 2015, Navya Sri Nizamkari wrote:
>
> > This patch removes if conditions with no exececutable
> > statements in the bodies of those ifs and also no
> > variable assignments in the if conditional checks.
> >
> > Signed-off-by: Navya Sri Nizamkari <navyas...@gmail.com <javascript:>>
> > ---
> > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 12 ------------
> > 1 file changed, 12 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> > index df0323f..c233a1c 100644
> > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> > @@ -572,10 +572,6 @@ static int r8192_wx_set_essid(struct net_device
> *dev,
> > struct r8192_priv *priv = rtllib_priv(dev);
> > int ret;
> >
> > - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> > - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
> > - ; /* TODO - get rid of if */
> > - }
>
> I'm not sure that this is correct. Can the call to rtllib_act_scanning
> have any side effects? If not, you should mention that explicitly in teh
> commit message.
>
> julia
>
Hi,
No, the call to rtllib_act_scanning has no side effects.
The function definition :
bool <http://lxr.free-electrons.com/ident?i=bool> rtllib_act_scanning <http://lxr.free-electrons.com/ident?i=rtllib_act_scanning>(struct rtllib_device <http://lxr.free-electrons.com/ident?i=rtllib_device> *ieee, bool <http://lxr.free-electrons.com/ident?i=bool> sync_scan)
{
if (ieee->softmac_features & IEEE_SOFTMAC_SCAN <http://lxr.free-electrons.com/ident?i=IEEE_SOFTMAC_SCAN>) {
if (sync_scan)
return ieee->be_scan_inprogress;
else
return ieee->actscanning || ieee->be_scan_inprogress;
} else {
return test_bit <http://lxr.free-electrons.com/ident?i=test_bit>(STATUS_SCANNING <http://lxr.free-electrons.com/ident?i=STATUS_SCANNING>, &ieee->status <http://lxr.free-electrons.com/ident?i=status>);
}
}
It doesn't make any other changes.
Thanks,
Navya
>
> > if (priv->bHwRadioOff == true) {
> > printk(KERN_INFO "=========>%s():hw radio off,or Rf
> state is "
> > "eRfOff, return\n", __func__);
> > @@ -708,11 +704,6 @@ static int r8192_wx_set_wap(struct net_device *dev,
> > int ret;
> > struct r8192_priv *priv = rtllib_priv(dev);
> >
> > - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> > - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN)) {
> > - ; /* TODO - get rid of if */
> > - }
> > -
> > if (priv->bHwRadioOff == true)
> > return 0;
> >
> > @@ -763,9 +754,6 @@ static int r8192_wx_set_enc(struct net_device *dev,
> > {0x00, 0x00, 0x00, 0x00, 0x00, 0x03} };
> > int i;
> >
> > - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> > - !(priv->rtllib->softmac_features & IEEE_SOFTMAC_SCAN))
> > - ; /* TODO - get rid of if */
> > if (priv->bHwRadioOff == true)
> > return 0;
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kern...@googlegroups.com <javascript:>.
> > To post to this group, send email to outreach...@googlegroups.com
> <javascript:>.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20150228215501.GA5201%40localhost.
>
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #1.2: Type: text/html, Size: 6874 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Remove if conditions.
2015-03-04 8:30 ` Navya Sri Nizamkari
@ 2015-03-04 22:32 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-03-04 22:32 UTC (permalink / raw)
To: Navya Sri Nizamkari; +Cc: outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3310 bytes --]
> No, the call to rtllib_act_scanning has no side effects.
>
> The function definition :
>
> bool rtllib_act_scanning(struct rtllib_device *ieee, bool sync_scan)
> {
> if (ieee->softmac_features & IEEE_SOFTMAC_SCAN) {
> if (sync_scan)
> return ieee->be_scan_inprogress;
> else
> return ieee->actscanning || ieee->be_scan_inprogres
> s;
> } else {
> return test_bit(STATUS_SCANNING, &ieee->status);
> }
> }
>
> It doesn't make any other changes.
OK, looks good.
julia
>
> Thanks,
> Navya
>
>
> > if (priv->bHwRadioOff == true) {
> > printk(KERN_INFO "=========>%s():hw radio
> off,or Rf state is "
> > "eRfOff, return\n", __func__);
> > @@ -708,11 +704,6 @@ static int r8192_wx_set_wap(struct
> net_device *dev,
> > int ret;
> > struct r8192_priv *priv = rtllib_priv(dev);
> >
> > - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> > - !(priv->rtllib->softmac_features &
> IEEE_SOFTMAC_SCAN)) {
> > - ; /* TODO - get rid of if */
> > - }
> > -
> > if (priv->bHwRadioOff == true)
> > return 0;
> >
> > @@ -763,9 +754,6 @@ static int r8192_wx_set_enc(struct
> net_device *dev,
> > {0x00, 0x00, 0x00, 0x00, 0x00,
> 0x03} };
> > int i;
> >
> > - if ((rtllib_act_scanning(priv->rtllib, false)) &&
> > - !(priv->rtllib->softmac_features &
> IEEE_SOFTMAC_SCAN))
> > - ; /* TODO - get rid of if */
> > if (priv->bHwRadioOff == true)
> > return 0;
> >
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@googlegroups.com.
> > To post to this group, send email to
> outreach...@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20150228215501.GA5201%40
> localhost.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/8f8344f2-dc88-4816-b7bc-
> 62536fc20f2d%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-04 22:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-28 21:55 [PATCH] staging: rtl8192e: Remove if conditions Navya Sri Nizamkari
2015-03-01 22:41 ` [Outreachy kernel] " Julia Lawall
2015-03-04 8:30 ` Navya Sri Nizamkari
2015-03-04 22:32 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.