* [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
@ 2015-03-01 21:00 Dilek Uzulmez
2015-03-01 21:02 ` [Outreachy kernel] " Daniel Baluta
2015-03-01 21:16 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dilek Uzulmez @ 2015-03-01 21:00 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
Fix checkpatch.pl issues with __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
index 2e5a9e5..d5b6887 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
@@ -244,12 +244,12 @@ do { \
int libcfs_debug_msg(struct libcfs_debug_msg_data *msgdata,
const char *format1, ...)
- __attribute__ ((format (printf, 2, 3)));
+ __printf(string-index, first-to-check);
int libcfs_debug_vmsg2(struct libcfs_debug_msg_data *msgdata,
const char *format1,
va_list args, const char *format2, ...)
- __attribute__ ((format (printf, 4, 5)));
+ __printf(string-index, first-to-check);
/* other external symbols that tracefile provides: */
int cfs_trace_copyin_string(char *knl_buffer, int knl_buffer_nob,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
2015-03-01 21:00 [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h Dilek Uzulmez
@ 2015-03-01 21:02 ` Daniel Baluta
2015-03-01 21:16 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Baluta @ 2015-03-01 21:02 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Sun, Mar 1, 2015 at 11:00 PM, Dilek Uzulmez <dilekuzulmez@gmail.com> wrote:
> Fix checkpatch.pl issues with __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
Hi,
Try to keep the subject smaller.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
2015-03-01 21:00 [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h Dilek Uzulmez
2015-03-01 21:02 ` [Outreachy kernel] " Daniel Baluta
@ 2015-03-01 21:16 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-01 21:16 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Sun, Mar 01, 2015 at 11:00:37PM +0200, Dilek Uzulmez wrote:
> Fix checkpatch.pl issues with __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
>
Along with fixing the subject, this is also too long of a line :(
Please fix and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-01 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-01 21:00 [PATCH] Staging: lustre: Fix __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h Dilek Uzulmez
2015-03-01 21:02 ` [Outreachy kernel] " Daniel Baluta
2015-03-01 21:16 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.