[PATCH] Staging: media: Add blank line after declarations

[PATCH] Staging: media: Add blank line after declarations

[Dilek Uzulmez]

The following patch fixes the checkpatch.pl warning:
drivers/staging/media/parport/bw-qcam.c WARNING: Missing a blank
line after declarations

Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
 drivers/staging/media/parport/bw-qcam.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/media/parport/bw-qcam.c b/drivers/staging/media/parport/bw-qcam.c
index 67b9da1..7f42b4b 100644
--- a/drivers/staging/media/parport/bw-qcam.c
+++ b/drivers/staging/media/parport/bw-qcam.c
@@ -601,6 +601,7 @@ static long qc_capture(struct qcam *q, u8 *buf, unsigned long len)
 			bytes = qc_readbytes(q, buffer);
 			for (k = 0; k < bytes && (pixels_read + k) < pixels_per_line; k++) {
 				int o;
+
 				if (buffer[k] == 0 && invert == 16) {
 					/* 4bpp is odd (again) -- inverter is 16, not 15, but output
 					   must be 0-15 -- bls */
@@ -609,6 +610,7 @@ static long qc_capture(struct qcam *q, u8 *buf, unsigned long len)
 				o = i * pixels_per_line + pixels_read + k;
 				if (o < len) {
 					u8 ch = invert - buffer[k];
+
 					got++;
 					buf[o] = ch << shift;
 				}
@@ -1108,6 +1110,7 @@ static int accept_bwqcam(struct parport *port)
 		for (n = 0; n < MAX_CAMS && parport[n]; n++) {
 			char *ep;
 			unsigned long r;
+
 			r = simple_strtoul(parport[n], &ep, 0);
 			if (ep == parport[n]) {
 				printk(KERN_ERR
@@ -1133,8 +1136,10 @@ static void bwqcam_attach(struct parport *port)
 static void bwqcam_detach(struct parport *port)
 {
 	int i;
+
 	for (i = 0; i < num_cams; i++) {
 		struct qcam *qcam = qcams[i];
+
 		if (qcam && qcam->pdev->port == port) {
 			qcams[i] = NULL;
 			close_bwqcam(qcam);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: media: Add blank line after declarations

[Greg KH]

On Fri, Feb 27, 2015 at 12:55:27PM +0200, Dilek Uzulmez wrote:
> The following patch fixes the checkpatch.pl warning:
> drivers/staging/media/parport/bw-qcam.c WARNING: Missing a blank
> line after declarations
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/media/parport/bw-qcam.c | 5 +++++
>  1 file changed, 5 insertions(+)

You sent 3 patches with the same subject, yet they did different things,
how am I supposed to know what to do here?

thanks,

greg k-h