Re: [Outreachy kernel] [PATCH 1/4] staging: lustre: Use kstrtol instead of sscanf.

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Mar 01, 2015 at 02:37:26PM +0530, Navya Sri Nizamkari wrote:
> Parsing error in sscanf returns a zero, while kstrtol returns
> non-zero.This patch changes sscanf into kstrtol by making
> appropriate changes in the case of parsing error conditional
> check to fix the following checkpatch.pl warning:
> 
> WARNING: Prefer kstrto<type> to single variable sscanf
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
>  drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
> index 26e8626..44d41dd 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_lib.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
> @@ -2150,7 +2150,7 @@ int ll_process_config(struct lustre_cfg *lcfg)
>  	ptr = strrchr(lustre_cfg_string(lcfg, 0), '-');
>  	if (!ptr || !*(++ptr))
>  		return -EINVAL;
> -	if (sscanf(ptr, "%lx", &x) != 1)
> +	if (kstrtol(ptr, 0, &x))
>  		return -EINVAL;
>  	sb = (void *)x;
>  	/* This better be a real Lustre superblock! */
> -- 
> 1.9.1

This doesn't apply to my tree :(