All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 2/4] staging: lustre: Remove unnecessary braces.
Date: Sun, 1 Mar 2015 16:50:10 -0800	[thread overview]
Message-ID: <20150302005010.GA23910@kroah.com> (raw)
In-Reply-To: <2c2bcdaacfd8142bbfc6f88c3efba38a4b1151e2.1425200447.git.navyasri.tech@gmail.com>

On Sun, Mar 01, 2015 at 02:38:02PM +0530, Navya Sri Nizamkari wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: braces {} are not necessary for any arm of
> this statement.
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
>  drivers/staging/lustre/lustre/llite/llite_lib.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
> index 44d41dd..e0e77cc 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_lib.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
> @@ -87,11 +87,10 @@ static struct ll_sb_info *ll_init_sbi(void)
>  
>  	si_meminfo(&si);
>  	pages = si.totalram - si.totalhigh;
> -	if (pages >> (20 - PAGE_CACHE_SHIFT) < 512) {
> +	if (pages >> (20 - PAGE_CACHE_SHIFT) < 512)
>  		lru_page_max = pages / 2;
> -	} else {
> +	else
>  		lru_page_max = (pages / 4) * 3;
> -	}
>  
>  	/* initialize lru data */
>  	atomic_set(&sbi->ll_cache.ccc_users, 0);
> -- 
> 1.9.1

Does not apply :(


  reply	other threads:[~2015-03-02  0:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01  9:06 [PATCH 0/4] staging: lustre: Fix warnings in llite_lib.c Navya Sri Nizamkari
2015-03-01  9:07 ` [PATCH 1/4] staging: lustre: Use kstrtol instead of sscanf Navya Sri Nizamkari
2015-03-02  0:49   ` [Outreachy kernel] " Greg KH
2015-03-01  9:08 ` [PATCH 2/4] staging: lustre: Remove unnecessary braces Navya Sri Nizamkari
2015-03-02  0:50   ` Greg KH [this message]
2015-03-01  9:08 ` [PATCH 3/4] staging: lustre: Remove whitespace Navya Sri Nizamkari
2015-03-02  0:50   ` [Outreachy kernel] " Greg KH
2015-03-01  9:09 ` [PATCH 4/4] staging: lustre: Remove space in function call Navya Sri Nizamkari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150302005010.GA23910@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=navyasri.tech@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.