From: Greg KH <gregkh@linuxfoundation.org>
To: Dilek Uzulmez <dilekuzulmez@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
Date: Sun, 1 Mar 2015 16:53:15 -0800 [thread overview]
Message-ID: <20150302005315.GA29313@kroah.com> (raw)
In-Reply-To: <1425240270-9001-1-git-send-email-dilekuzulmez@gmail.com>
On Sun, Mar 01, 2015 at 10:04:30PM +0200, Dilek Uzulmez wrote:
> Fix checkpatch.pl issues with __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> index 4688770..a989d26 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> @@ -107,7 +107,7 @@ typedef struct lustre_kernelcomm {
> __u32 lk_group;
> __u32 lk_data;
> __u32 lk_flags;
> -} __attribute__((packed)) lustre_kernelcomm;
> +} __packed lustre_kernelcomm;
Can you also work to get rid of this typedef?
thanks,
greg k-h-
prev parent reply other threads:[~2015-03-02 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 20:04 [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h Dilek Uzulmez
2015-03-02 0:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302005315.GA29313@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dilekuzulmez@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.