* [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
@ 2015-03-01 20:04 Dilek Uzulmez
2015-03-02 0:53 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Dilek Uzulmez @ 2015-03-01 20:04 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
Fix checkpatch.pl issues with __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
index 4688770..a989d26 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
@@ -107,7 +107,7 @@ typedef struct lustre_kernelcomm {
__u32 lk_group;
__u32 lk_data;
__u32 lk_flags;
-} __attribute__((packed)) lustre_kernelcomm;
+} __packed lustre_kernelcomm;
/* Userspace methods */
int libcfs_ukuc_start(lustre_kernelcomm *l, int groups);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
2015-03-01 20:04 [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h Dilek Uzulmez
@ 2015-03-02 0:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-03-02 0:53 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Sun, Mar 01, 2015 at 10:04:30PM +0200, Dilek Uzulmez wrote:
> Fix checkpatch.pl issues with __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> index 4688770..a989d26 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
> @@ -107,7 +107,7 @@ typedef struct lustre_kernelcomm {
> __u32 lk_group;
> __u32 lk_data;
> __u32 lk_flags;
> -} __attribute__((packed)) lustre_kernelcomm;
> +} __packed lustre_kernelcomm;
Can you also work to get rid of this typedef?
thanks,
greg k-h-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-02 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-01 20:04 [PATCH] Staging: lustre: Fix __packed is preferred over __attribute__((packed)) in libcfs_kernelcomm.h Dilek Uzulmez
2015-03-02 0:53 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.