[PATCH v2] Staging: lustre: Replace __printf(string-index, first-to-check) with __attribute__((format(printf, string-index, first-to-check)))

[PATCH v2] Staging: lustre: Replace __printf(string-index, first-to-check) with __attribute__((format(printf, string-index, first-to-check)))

[Dilek Uzulmez]

Fix checkpatch.pl issues with __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h

Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---

Changes in v2:
   Changed subject line
 
 drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
index 2e5a9e5..d5b6887 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h
@@ -244,12 +244,12 @@ do {									\
 
 int libcfs_debug_msg(struct libcfs_debug_msg_data *msgdata,
 			    const char *format1, ...)
-	__attribute__ ((format (printf, 2, 3)));
+	__printf(string-index, first-to-check);
 
 int libcfs_debug_vmsg2(struct libcfs_debug_msg_data *msgdata,
 			      const char *format1,
 			      va_list args, const char *format2, ...)
-	__attribute__ ((format (printf, 4, 5)));
+	__printf(string-index, first-to-check);
 
 /* other external symbols that tracefile provides: */
 int cfs_trace_copyin_string(char *knl_buffer, int knl_buffer_nob,
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2] Staging: lustre: Replace __printf(string-index, first-to-check) with __attribute__((format(printf, string-index, first-to-check)))

[Greg KH]

On Sun, Mar 01, 2015 at 11:07:35PM +0200, Dilek Uzulmez wrote:
> Fix checkpatch.pl issues with __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check))) in libcfs_debug.h
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> 
> Changes in v2:
>    Changed subject line

You obviously did not even compile this patch, why not?  It's a bit rude
to break the build :(

Please be more careful.