[PATCH] Staging: emxx_udc: Remove argument test from function

[PATCH] Staging: emxx_udc: Remove argument test from function

[Haneen Mohammed]

This patch removes the test statement for an argument to  _nbu2ss_pullup function,
for it can't be null due to previous derefrences when its called.

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
 drivers/staging/emxx_udc/emxx_udc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 0bfd268..b2a89a6 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -2257,11 +2257,6 @@ static int _nbu2ss_pullup(struct nbu2ss_udc *udc, int is_on)
 {
 	u32	reg_dt;
 
-	if (!udc) {
-		pr_err("udc: %s, bad param\n", __func__);
-		return -EINVAL;
-	}
-
 	if (udc->vbus_active == 0)
 		return -ESHUTDOWN;
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Remove argument test from function

[Julia Lawall]

On Mon, 2 Mar 2015, Haneen Mohammed wrote:

> This patch removes the test statement for an argument to  _nbu2ss_pullup function,
> for it can't be null due to previous derefrences when its called.

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 0bfd268..b2a89a6 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -2257,11 +2257,6 @@ static int _nbu2ss_pullup(struct nbu2ss_udc *udc, int is_on)
>  {
>  	u32	reg_dt;
>
> -	if (!udc) {
> -		pr_err("udc: %s, bad param\n", __func__);
> -		return -EINVAL;
> -	}
> -
>  	if (udc->vbus_active == 0)
>  		return -ESHUTDOWN;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1425244693-8713-1-git-send-email-hamohammed.sa%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Remove argument test from function

[Greg KH]

On Mon, Mar 02, 2015 at 12:18:13AM +0300, Haneen Mohammed wrote:
> This patch removes the test statement for an argument to  _nbu2ss_pullup function,
> for it can't be null due to previous derefrences when its called.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>  drivers/staging/emxx_udc/emxx_udc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index 0bfd268..b2a89a6 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -2257,11 +2257,6 @@ static int _nbu2ss_pullup(struct nbu2ss_udc *udc, int is_on)
>  {
>  	u32	reg_dt;
>  
> -	if (!udc) {
> -		pr_err("udc: %s, bad param\n", __func__);
> -		return -EINVAL;
> -	}
> -
>  	if (udc->vbus_active == 0)
>  		return -ESHUTDOWN;
>  

Does not apply :(